-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUMULUS-350 Update queue-granules to use cumulus-message-adapter #227
Conversation
Removes a lot of extra logic from the granule queueing function.
In addition to updating the queue-granules task to use the message adapter, this PR also greatly simplifies the granule queuing code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
* See schemas/input.json and schemas/config.json for detailed event description | ||
* | ||
* @param {Object} event - Lambda event object | ||
* @returns {Promise} - see schemas/output.json for detailed output schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is returning an Object, not a Promise, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an async function, so it's returning a Promise.
@@ -39,6 +39,7 @@ | |||
"license": "Apache-2.0", | |||
"dependencies": { | |||
"@cumulus/common": "^1.0.1", | |||
"@cumulus/cumulus-message-adapter-js": "0.0.1-beta.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this 1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created CUMULUS-367 to deal with this.
No description provided.