CUMULUS-1748: support relative paths in recursion.js #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemreid
commented
Feb 19, 2020
markdboyd
suggested changes
Feb 20, 2020
| @@ -45,10 +45,11 @@ while ! $docker_command 'curl --connect-timeout 5 -sS -o /dev/null http://127.0 | |||
| done | |||
| echo 'HTTP service is available' | |||
|
|
|||
| $docker_command "mkdir /keys;cp $UNIT_TEST_BUILD_DIR/packages/test-data/keys/ssh_client_rsa_key /keys/; chmod -R 400 /keys" | |||
There was a problem hiding this comment.
Is the idea behind making it a root directory (/keys) instead of in the test-data directory to avoid it being crawled by the FTP discovery tests and having issues due to directory permissions?
There was a problem hiding this comment.
It is both that and the fact that SFTP requires the key permissions to be 400.
Changing the way we react to running into a directory we can't access seemed out of scope for this PR but would be required for everything not to bomb out on encountering a directory that does not allow reads.
This reverts commit 922ddd4.
markdboyd
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-1748: relative paths in recursion
Changes
PR Checklist