Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUMULUS-3892: Update the home page metrics overview section #1154

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Nnaga1
Copy link
Contributor

@Nnaga1 Nnaga1 commented Oct 16, 2024

Summary: Summary of changes

Addresses CUMULUS-3892: Dashboard - Home Page Metrics Overview Section Update

Changes

  • Code: Update timeframe to the past 24 hours
  • UI: Add a label to inform user of the timeframe

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Adhoc testing
  • Integration tests

@Nnaga1 Nnaga1 added the Needs Review Looking for a reviewer label Oct 16, 2024
@jjmccoy jjmccoy self-assigned this Oct 16, 2024
@jjmccoy jjmccoy added In Review and removed Needs Review Looking for a reviewer labels Oct 16, 2024
@jjmccoy
Copy link
Member

jjmccoy commented Oct 16, 2024

@Nnaga1 This looks good. I believe there is a cypress test for the home page: main_page_spec.js. That may need updating for the timeframe update change. If not, just lmk.

@jjmccoy
Copy link
Member

jjmccoy commented Oct 16, 2024

@Nnaga1

FYI: So if the user goes to another page and comes back to the home page, the stats from that page temporarily bring those over to the home page and it refreshes. In this video example, it is Rules (for ingest) that has 34 currently. For this, I would suggest creating a ticket for the issue because it is outside the scope of your ticket but may need to be addressed so that users are not confused or think the information is misleading.

Action needed: Create new ticket

Screen.Recording.2024-10-16.at.12.14.05.PM.mov

@Nnaga1
Copy link
Contributor Author

Nnaga1 commented Oct 16, 2024

@Nnaga1

FYI: So if the user goes to another page and comes back to the home page, the stats from that page temporarily bring those over to the home page and it refreshes. In this video example, it is Rules (for ingest) that has 34 currently. For this, I would suggest creating a ticket for the issue because it is outside the scope of your ticket but may need to be addressed so that users are not confused or think the information is misleading.

Action needed: Create new ticket

Screen.Recording.2024-10-16.at.12.14.05.PM.mov

Dang I was unaware of that, thanks for lmk, I'll try to see if I can figure it out within this ticket, if not I'll create another, thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants