Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUMULUS-3748: Remove or fix call to /stats/aggregate for Reconciliation Reports #1152

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Nnaga1
Copy link
Contributor

@Nnaga1 Nnaga1 commented Oct 15, 2024

Summary: Summary of changes

Addresses CUMULUS-XX: Develop amazing new feature

Changes

  • Detailed list or prose of changes
  • ...

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Adhoc testing
  • Integration tests

@Nnaga1
Copy link
Contributor Author

Nnaga1 commented Oct 15, 2024

to fix the call for the reconciliationReports, it has to be done API-side, in the file : cumulus/packages/api/endpoints/stats.js. In this file, we can see that ‘reconciliationReports’ is not a defined type in ‘getType’, so for this query: /stats/aggregate?type=reconciliationReports&field=type, it will trigger this error in that API file: return res.boom.badRequest('Type must be included in Stats Aggregate query string parameters’); , since getType would return undefined

so two action items from this:
- should reconciliationReports be added to getType as a supported type? if it is then the query would work after the work of CUMULUS-3718 is merged,
it should probably be added in that PR as well (as it is a small change now that reconciliationReports is in SQL)
- should the dashboard add an aggregate stats or summary call for the ReconciliationReports page? essentially moving the query from granules to there, it currently
doesn’t seem to call stats aggregate from the reconReports page

For now I will proceed in deleting that call from the Granules page, and create another ticket or comment on related tickets about my findings/thoughts.

@Nnaga1 Nnaga1 added the Needs Review Looking for a reviewer label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Looking for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant