Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #77, use cfe.h instead of individual headers #78

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Mar 9, 2021

Describe the contribution
Use cfe.h in ci_lab rather than the individual component-specific headers.

The all-inclusive header should give everything needed, and be more future proof in case component names ever need to change.

Fixes #77

Testing performed
Build and sanity check CFE

Expected behavior changes
No impact

System(s) tested on
Ubuntu 20.04

Additional context
Needed for nasa/cFE#1203

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

The all-inclusive header should give everything needed, and be
more future proof in case component names ever need to change.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Mar 9, 2021
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend fast-track.

@astrogeco astrogeco added CCB:FastTrack and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Mar 11, 2021
@astrogeco astrogeco merged commit e35bbec into nasa:main Mar 11, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Mar 11, 2021
astrogeco added a commit to astrogeco/cFS that referenced this pull request Mar 12, 2021
@jphickey jphickey deleted the fix-77-use-cfe-h branch June 8, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applications should use all-inclusive "cfe.h" header
3 participants