IC 20200304 #38
Merged
IC 20200304 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code has numerous quality issues and has repeatedly been a maintenance problem, and also is of questionable usefulness. It was agreed in the CCB to drop this feature.
This removes the need to use BSD socket calls directly within CI_LAB
Make the patterns in CI better match the patterns used in other modules (CFE core, Sample App, etc) - Separate each command into a separate handler function - Each command handler accepts a const pointer to the full message - Put Telemetry payload into a separate "Payload" sub-structure - Use naming conventions defined in conventions document Note the payload name changes only affect the FSW internal usage, the payload format for the ground system is not changed.
Add a global structure called "CI_LAB_Global" for all globals, getting them out of the global namespace. All other identifiers that remain in the global namespace should be prefixed consistently with CI_LAB_ to match the name of the app.
Multiple cleanup items for CI LAB
This was
linked to
issues
Mar 10, 2020
Remove deprecated sudo key Add os key Fix language key formatting
Fix #39, Clang-format-10 fails in Travis CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration candidate 20200304
Fixes #23, #27, #34, #36, and #39
See PR #35 for more details
Testing performed
CI Testing only
Expected behavior changes
#23 - Use OSAL socket API instead of BSD sockets
#27 - Drop PDU introspection code
#34 - Update command and telemetry logic to match other modules and recommended conventions
#36 - Collect globals as a single top-level global structure
#39 - ci again runs with clang-format
System(s) tested on
OS: Ubuntu-Bionic
Additional context
See PR #35 and #40 for more details
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey- Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz - NASA/GSFC