-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #129, Apply consistent Event ID names to common events #130
Fix #129, Apply consistent Event ID names to common events #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to get these into the next round
47cc323
to
50f9947
Compare
50f9947
to
ffb9401
Compare
ffb9401
to
60626f1
Compare
I did the rebase on this one, but I think we may have done at the same time.... |
haha woops - tried to save you the trouble... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased changes look correct
Probably the rest of the PRs will need a rebase too, if you want to look, I'll hold off |
Yes I'll go through them now mate. |
@jphickey all cleared up now I think |
Checklist
Describe the contribution
Testing performed
Only GitHub CI actions.
Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.
Contributor Info
Avi Weiss @thnkslprpt