Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function prototypes can be moved out of ci_lab_app.c #140

Closed
2 tasks done
thnkslprpt opened this issue May 2, 2023 · 0 comments · Fixed by #141
Closed
2 tasks done

Function prototypes can be moved out of ci_lab_app.c #140

thnkslprpt opened this issue May 2, 2023 · 0 comments · Fixed by #141

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
These prototypes can/should be moved out of ci_lab_app.c into the header file, along with the global data struct definition.

Code snips

typedef struct
{
bool SocketConnected;
CFE_SB_PipeId_t CommandPipe;
osal_id_t SocketID;
OS_SockAddr_t SocketAddress;
CI_LAB_HkTlm_t HkTlm;
CFE_SB_Buffer_t *NextIngestBufPtr;
} CI_LAB_GlobalData_t;
CI_LAB_GlobalData_t CI_LAB_Global;
/*
* Individual message handler function prototypes
*
* Per the recommended code pattern, these should accept a const pointer
* to a structure type which matches the message, and return an int32
* where CFE_SUCCESS (0) indicates successful handling of the message.
*/
int32 CI_LAB_Noop(const CI_LAB_NoopCmd_t *data);
int32 CI_LAB_ResetCounters(const CI_LAB_ResetCountersCmd_t *data);
/* Housekeeping message handler */
int32 CI_LAB_ReportHousekeeping(const CFE_MSG_CommandHeader_t *data);

Expected behavior
Consistent content of implementation/header files across cFS.

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/ci_lab that referenced this issue May 2, 2023
thnkslprpt added a commit to thnkslprpt/ci_lab that referenced this issue Nov 1, 2023
thnkslprpt added a commit to thnkslprpt/ci_lab that referenced this issue Nov 1, 2023
dmknutsen added a commit that referenced this issue Nov 8, 2023
…ader-file

Fix #140, Move function prototypes to header file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant