cFE Integration candidate: 2021-05-11 #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CFE framework build uses mostly default values for OSAL compile time configuration. There are just a few exceptions where the CFE build is tuned for a more debug-friendly result. This updates the configuration files in "sample_defs" to reflect only those values which are set to a non-default value, along with information about why the configurable item is changed. Currently, these are only items related to debugging. This change also includes more documentation/comments about how this configuration facility works and where to find information on the complete set of options available (which is OSAL version dependent).
By setting OSAL_CONFIG_UTILITYTASK_PRIORITY in the "native_osconfig" file instead of the default file, it will only apply when building with SIMULATION=native. Deployment builds will use the low priority default value.
Update CFE core stub libraries to use generated stubs, using the generator script now part of UT Assert. All existing stub logic is converted to a default handler routine. This also entailed moving all of the internal API prototypes to be in the "core_private" interface lib rather than in "core_api". The only reason this was not done earlier was due to issues with the stubs, but that is alleviated when using generated stubs.
This function should only be called internally from ES and therefore does not need to be in public API.
CCB 2021-05-05 review item, matches name used in code.
Fix #1486, Remove broken travis-ci script
This uses a sub-script to call elf2cfetbl which avoid relying on a shell glob. More complicated but should be more robust if/when someone renames a table. Note: A proper/simpler fix would still be to use TARGET_OBJECTS generator expression, but that can't happen until Ubuntu 18.04 (w/ ver 3.10) or older versions are no longer supported.
Fix #1436, table object file name
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2021
nasa/cFE#1492, cFE v6.8.0-rc1+dev575 nasa/osal#996, osal v5.1.0-rc1+dev434 nasa/cFE#1487, Remove broken travis-ci script nasa/cFE#1463, generated coverage stubs for CFE core nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API nasa/cFE#1451, OSAL config file simplification nasa/cFE#1489, removes --quiet option so files checked go to stdout nasa/osal#978, configuration guide updates nasa/osal#974, improve documentation of UtAssert API calls nasa/osal#977, update OS_TaskCreate doc nasa/osal#997, Enable cppcheck results output nasa/osal#980, Scrub return values nasa/osal#992, add local mutex to BSP console nasa/osal#993, do not require nonblock mode
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2021
nasa/cFE#1492, cFE v6.8.0-rc1+dev575 nasa/osal#996, osal v5.1.0-rc1+dev434 nasa/cFE#1487, Remove broken travis-ci script nasa/cFE#1463, generated coverage stubs for CFE core nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API nasa/cFE#1451, OSAL config file simplification nasa/cFE#1489, removes --quiet option so files checked go to stdout nasa/osal#978, configuration guide updates nasa/osal#974, improve documentation of UtAssert API calls nasa/osal#977, update OS_TaskCreate doc nasa/osal#997, Enable cppcheck results output nasa/osal#980, Scrub return values nasa/osal#992, add local mutex to BSP console nasa/osal#993, do not require nonblock mode Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of nasa/cFS#256
Testing
cFE Checks https://github.com/nasa/cFE/pull/1492/checks
cFS Bundle Checks https://github.com/nasa/cFS/pull/256/checks
Description
PR #1487
Fix #1486, Remove broken travis-ci script
PR #1463
Fix #1417, generated coverage stubs for CFE core
Updates CFE core stub libraries to use stubs generated from new UT Assert script. Converts existing stub logic to
a default handler routine.
Moves all of the internal API prototypes from "core_api" to the "core_private" interface lib.
Fix #1393, Move CFE_FS_RunBackgroundFileDump to internal API
Update #1463, rename hook files to handler
PR #1451
Fix #1343, OSAL config file simplification
Adds documentation and comments about how the configuration facility works and where to find information on the complete set of options available
Updates the configuration files in "sample_defs" to reflect only those parameters that are set to a non-default value along with information about why the configurable item is changed.
PR #1489
Fix #1488, removes --quiet option so files checked go to stdout
PR #1437
Fix #1436, table object file name
Authors
@jphickey
@skliper