Fix #1343, OSAL config file simplification #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CFE framework build uses mostly default values for OSAL compile time configuration. There are just a few exceptions where the CFE build is tuned for a more debug-friendly result. This updates the configuration files in "sample_defs" to reflect only those values which are set to a non-default value, along with information about why the configurable item is changed. Currently, these are only items related to debugging. This change also includes more documentation/comments about how this configuration facility works and where to find information on the complete set of options available (which is OSAL version dependent).
jphickey
added
the
CCB:Ready
skliper
approved these changes
Apr 29, 2021
|
CCB:2021-05-05 APPROVED |
astrogeco
added
the
CCB:Approved
By setting OSAL_CONFIG_UTILITYTASK_PRIORITY in the "native_osconfig" file instead of the default file, it will only apply when building with SIMULATION=native. Deployment builds will use the low priority default value.
|
Talked with Joe. Concern is that an inexperienced user might leave OSAL_CONFIG_UTILITYTASK_PRIORITY set high and see intermittent bad/non-deterministic real-time behavior. Maybe even losing a mission. You want to be very clear that setting a high priority is a bad idea for real-time flight systems. |
|
Pushed update to resolve @jwilmot's concerns - this just moves the setting of the See commit 63d11eb |
astrogeco
added
IC:2021-05-11
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 11, 2021
nasa/cFE#1487, Remove broken travis-ci script nasa/cFE#1463, generated coverage stubs for CFE core nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API nasa/cFE#1451, OSAL config file simplification
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2021
nasa/cFE#1492, cFE v6.8.0-rc1+dev575 nasa/osal#996, osal v5.1.0-rc1+dev434 nasa/cFE#1487, Remove broken travis-ci script nasa/cFE#1463, generated coverage stubs for CFE core nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API nasa/cFE#1451, OSAL config file simplification nasa/cFE#1489, removes --quiet option so files checked go to stdout nasa/osal#978, configuration guide updates nasa/osal#974, improve documentation of UtAssert API calls nasa/osal#977, update OS_TaskCreate doc nasa/osal#997, Enable cppcheck results output nasa/osal#980, Scrub return values nasa/osal#992, add local mutex to BSP console nasa/osal#993, do not require nonblock mode
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2021
nasa/cFE#1492, cFE v6.8.0-rc1+dev575 nasa/osal#996, osal v5.1.0-rc1+dev434 nasa/cFE#1487, Remove broken travis-ci script nasa/cFE#1463, generated coverage stubs for CFE core nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API nasa/cFE#1451, OSAL config file simplification nasa/cFE#1489, removes --quiet option so files checked go to stdout nasa/osal#978, configuration guide updates nasa/osal#974, improve documentation of UtAssert API calls nasa/osal#977, update OS_TaskCreate doc nasa/osal#997, Enable cppcheck results output nasa/osal#980, Scrub return values nasa/osal#992, add local mutex to BSP console nasa/osal#993, do not require nonblock mode Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The CFE framework build uses mostly default values for OSAL compile time configuration. There are just a few exceptions where the CFE build is tuned for a more debug-friendly result.
This updates the configuration files in "sample_defs" to reflect only those values which are set to a non-default value, along with
information about why the configurable item is changed. Currently, these are only items related to debugging.
This change also includes more documentation/comments about how this configuration facility works and where to find information on the complete set of options available (which is OSAL version dependent).
Fixes #1343
Testing performed
Build and sanity check CFE, run all tests
Expected behavior changes
None, this is just documentation/sample config cleanup, but does not change the effective OSAL configuration, since most of the values in this sample file were the same as the default value.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.