-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #979, add fields to task info struct #1159
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs a rebase, pushed as draft for review. Change is in commit 015607b |
skliper
approved these changes
Feb 18, 2021
Is this ready for rebase/link to issue/review? |
Add the task info and priority to the data structure written by the QUERY_ALL_TASKS command. Leaving out entry point, as it would be a memory address and not useful/relevant outside the process.
jphickey
force-pushed
the
fix-979-taskinfo
branch
from
February 26, 2021 19:05
015607b
to
2888450
Compare
This should be good to merge - The CodeQL failure reported is not valid / unrelated - need to figure out how to force a re-run... |
jphickey
added
the
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
label
Mar 3, 2021
astrogeco
added
CCB:2021-03-03
and removed
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
labels
Mar 3, 2021
CCB 2021-03-03 APPROVED |
This has been merged successfully, closing manually because it had the wrong base (main vs. integration-candidate) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Adds stack size and priority to the task info structure written by
CFE_ES_QUERY_ALL_TASKS_CC
command.Fixes #979
Testing performed
Build and run CFE, issue QUERY_ALL_TASKS command, confirm data is in the resulting file.
Run all unit tests.
Expected behavior changes
Adds two new fields to the file produced by the command.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.