Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #979, add fields to task info struct #1159

Closed

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Feb 8, 2021

Describe the contribution

Adds stack size and priority to the task info structure written by CFE_ES_QUERY_ALL_TASKS_CC command.

Fixes #979

Testing performed
Build and run CFE, issue QUERY_ALL_TASKS command, confirm data is in the resulting file.
Run all unit tests.

Expected behavior changes
Adds two new fields to the file produced by the command.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Copy link
Contributor Author

jphickey commented Feb 8, 2021

Needs a rebase, pushed as draft for review. Change is in commit 015607b

@skliper
Copy link
Contributor

skliper commented Feb 18, 2021

Is this ready for rebase/link to issue/review?

@jphickey
Copy link
Contributor Author

Is this ready for rebase/link to issue/review?

Corrected the link to issue #979. As for rebase it depends on PR #1151 being merged first so I'm waiting for that baseline.

Add the task info and priority to the data structure written by
the QUERY_ALL_TASKS command.  Leaving out entry point, as it would
be a memory address and not useful/relevant outside the process.
@jphickey jphickey marked this pull request as ready for review February 26, 2021 20:46
@jphickey
Copy link
Contributor Author

This should be good to merge - The CodeQL failure reported is not valid / unrelated - need to figure out how to force a re-run...

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 3, 2021
@astrogeco astrogeco added CCB:2021-03-03 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Mar 3, 2021
@astrogeco
Copy link
Contributor

CCB 2021-03-03 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate March 4, 2021 19:45
@skliper skliper added this to the 7.0.0 milestone Mar 5, 2021
@skliper skliper self-assigned this Mar 5, 2021
@jphickey
Copy link
Contributor Author

jphickey commented Mar 5, 2021

This has been merged successfully, closing manually because it had the wrong base (main vs. integration-candidate)

@jphickey jphickey closed this Mar 5, 2021
@jphickey jphickey deleted the fix-979-taskinfo branch March 10, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report task details in QUERY_ALL_TASKS command
3 participants