-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #583, Fetch Documentation Archives #589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good, but there's some badness in the changelog:
/home/runner/work/cFS/cFS/psp/CHANGELOG.md:120: warning: explicit link request to 'includes' could not be resolved
@skliper I was just about to ask you about this warning. Line 120 just points to https://github.com/nasa/PSP/blob/78baa2091fd1636ac6bf613d1d78308c977334dc/CHANGELOG.md?plain=1#L120. So I assume this line is the issue: https://github.com/nasa/PSP/blob/78baa2091fd1636ac6bf613d1d78308c977334dc/CHANGELOG.md?plain=1#L94 correct? |
Yeah, I'm not sure why it's saying 120. To resolve though one easy option would be to just exclude the |
*Combines:* cfe v7.0.0-rc4+dev197 osal v7.0.0-rc4+dev143 psp v1.6.0-rc4+dev61 elf2cfetbl v3.4.0-rc4+dev30 sch_lab v2.5.0-rc4+dev45 **Includes:** *cFS* - #589 *cFE* - nasa/cFE#2165 *osal* - nasa/osal#1311 - nasa/osal#1310 - nasa/osal#1313 - nasa/osal#1306 - nasa/osal#1309 *psp* - nasa/PSP#365 - nasa/PSP#368 *sch_lab* - nasa/sch_lab#126 *elf2cfetbl* - nasa/elf2cfetbl#119 Co-authored-by: Avi Weiss <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Ariel Adams <[email protected]>
*Combines:* cfe v7.0.0-rc4+dev197 osal v7.0.0-rc4+dev143 psp v1.6.0-rc4+dev61 elf2cfetbl v3.4.0-rc4+dev30 sch_lab v2.5.0-rc4+dev45 **Includes:** *cFS* - #589 *cFE* - nasa/cFE#2165 *osal* - nasa/osal#1311 - nasa/osal#1310 - nasa/osal#1313 - nasa/osal#1306 - nasa/osal#1309 *psp* - nasa/PSP#365 - nasa/PSP#368 *sch_lab* - nasa/sch_lab#126 *elf2cfetbl* - nasa/elf2cfetbl#119 Co-authored-by: Avi Weiss <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Ariel Adams <[email protected]>
Checklist (Please check before submitting)
Describe the contribution
Fixes #583
Testing performed
Tested on fork
Tested locally in Docker.
Additional context
The issue is thrown at random times. Thrown here: https://github.com/nasa/cFS/actions/runs/3185348707/jobs/5194900560 but not here: https://github.com/nasa/cFS/actions/runs/3185232492/jobs/5194803479.
Expected behavior changes
Fixes failing cFS Documentation and Guides workflow. It had an issue installing PDF generation dependencies. Same behavior.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, MCSG Tech