Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 43, updates instructions from python2-->3 #44

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

dmknutsen
Copy link
Contributor

Describe the contribution
Fix #43, Updates README file to reflect upgrade from python 2-->3 in GroundSystem.py scripts.

Steps taken to test the contribution:
Launched GroundSystem.py tool using the updated instruction.

Expected behavior changes:
README.md is now updated to reflect upgrade to python3.

System(s) tested on:
Oracle VM VirtualBox
OS: ubuntu-19.10
Versions: cFE 6.7.6.0, OSAL 5.0.6.0, PSP 1.4.4.0

Contributor Info:
Dan Knutsen
GSFC/NASA

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 25, 2020
@astrogeco
Copy link
Contributor

@dmknutsen please update the title to the right format: Fix #NUM, TITLE

@astrogeco
Copy link
Contributor

CCB 20200226 - Approved

@astrogeco astrogeco added CCB - 20200226 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Feb 26, 2020
@astrogeco astrogeco changed the base branch from master to ic-20200226 March 9, 2020 15:02
@astrogeco astrogeco merged commit 6f3aab0 into nasa:ic-20200226 Mar 9, 2020
@astrogeco astrogeco mentioned this pull request Mar 10, 2020
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
For unit unit tests that invoke CF PDU processing functions
on either input or output, ensure that the locally instantiated
"dummy" PDU is both sized sufficiently and aligned correctly.

This removes quite a bit of questionable casting between the
buffer types, and fixes a number of stack-smashing issues.

For completeness, this also clears (memset to 0) all instantiated
buffers, before setting values in the test.  This ensures that the
entire message structure has predictable/repeatable content.
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Fix nasa#44, nasa#46, instantiate properly sized and aligned buffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cFS-GroundSystem instructions in README
3 participants