Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #595, Remove obsolete lgtm config file #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #595, Remove obsolete lgtm config file #596

wants to merge 1 commit into from

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Oct 14, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI

Expected behavior changes
None

System(s) tested on
CI

Additional context
None

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Oct 14, 2022
@skliper
Copy link
Contributor Author

skliper commented Oct 14, 2022

Heads up @dmknutsen @dzbaker, looks like there's some real failures that started recently in CI: https://github.com/nasa/cFS/actions/runs/3230286177 (also causing the issue w/ this one). There's also quite a few (8 of the workflows) deprecation warnings popping up in CI: https://github.com/nasa/cFS/pull/590/checks. Some are just Ubuntu, but it looks like there's others.

@dzbaker
Copy link
Contributor

dzbaker commented Oct 14, 2022

Heads up @dmknutsen @dzbaker, looks like there's some real failures that started recently in CI: https://github.com/nasa/cFS/actions/runs/3230286177 (also causing the issue w/ this one). There's also quite a few (8 of the workflows) deprecation warnings popping up in CI: https://github.com/nasa/cFS/pull/590/checks. Some are just Ubuntu, but it looks like there's others.

@skliper Thanks for the heads up! I believe these PRs should resolve at least some of the failures: #589 and nasa/cFE#2165. I should be merging the PRs fairly soon (I'm just waiting on a couple of fixes to other PRs going into the bundle).

@skliper
Copy link
Contributor Author

skliper commented Oct 14, 2022

Looks like the org owners have to uninstall the lgtm.com app from the repos to actually remove the analysis and related warnings. I'll put in a request.

@dzbaker
Copy link
Contributor

dzbaker commented Oct 14, 2022

Looks like the org owners have to uninstall the lgtm.com app from the repos to actually remove the analysis and related warnings. I'll put in a request.

Ok, thanks!

@skliper skliper added CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove obsolete lgtm config file
2 participants
@skliper @dzbaker