Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Full Path for Queries in CodeQL #261

Closed
3 tasks done
ArielSAdamsNASA opened this issue May 26, 2021 · 0 comments · Fixed by #262
Closed
3 tasks done

Use Full Path for Queries in CodeQL #261

ArielSAdamsNASA opened this issue May 26, 2021 · 0 comments · Fixed by #262

Comments

@ArielSAdamsNASA
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the cFS README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Repositories will be using the configuration files in cFS rather than using duplicate configuration files in their own repos. Some CodeQL workflows do not work unless the full path of the queries are used such as PSP, nasa/PSP#292.

Describe the solution you'd like
Use the full path for queries in CodeQL. For example, instead of ./codeql/cpp/ql/src/JPL_C use github/codeql/cpp/ql/src/JPL_C@main. Some repositories such as cFE does not require the full path.

Describe alternatives you've considered
N/A

Additional context
Tested this locally. The PSP was throwing the error "The configuration file "nasa/cFS/.github/codeql/codeql-coding-standard.yml@main" is invalid: property "queries.uses" is invalid as the local path "codeql/cpp/ql/src/JPL_C" does not exist in the repository". This error goes away when the full path for the queries are used.

Requester Info
Ariel Adams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants