-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #172, updating executable name and version in setup.py #174
fix #172, updating executable name and version in setup.py #174
Conversation
Thanks for the PR! |
@zachar1a can you isolate the commit for each fix in it's own PR? You can use Also edit the commit message to follow the standard format You
Thanks for contributing and for being patient as we iron out the kinks in our contribution flows! |
@astrogeco I had made a separate branch for each pr. Should I just do one fix at a time? |
When I run the install command I am getting this error. /cFS$ pip3 install -e tools/cFS-GroundSystem |
Can you still run the tool with python3 /cFS-GroundSystem.py |
yes, python3 GroundSystem.py still works for me. |
Is it possible for you to delete the GroundSystem dir and then reinstall it |
That fixed it. |
As for the commits and branches. Typically we do one branch per fix and PR so this one is good. The only thing I would change is the capitalization on the "fix" in the message. I'll comment on the other one as well |
Ok I'll be sure to double check it for next time. |
nasa/cFS-GroundSystem#174 update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
Describe the contribution
A clear and concise description of what the contribution is.
-Changing executable command from 'startg' to 'cFS-GroundSystem'
-Changing version to be the version stated in version.py
Testing performed
Steps taken to test the contribution:
made sure new executable command works
Expected behavior changes
Changing executable command from 'startg' to 'cFS-GroundSystem'
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Zachary Gonzalez - Personal