Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #172, updating executable name and version in setup.py #174

Merged
merged 1 commit into from
Apr 21, 2021
Merged

fix #172, updating executable name and version in setup.py #174

merged 1 commit into from
Apr 21, 2021

Conversation

zachar1a
Copy link
Contributor

Describe the contribution
A clear and concise description of what the contribution is.
-Changing executable command from 'startg' to 'cFS-GroundSystem'
-Changing version to be the version stated in version.py

Testing performed
Steps taken to test the contribution:
made sure new executable command works

Expected behavior changes
Changing executable command from 'startg' to 'cFS-GroundSystem'

System(s) tested on

  • Hardware: MacBook Pro
  • OS: macOS Big Sur
  • Versions: 11.2.3

Contributor Info - All information REQUIRED for consideration of pull request
Zachary Gonzalez - Personal

@astrogeco astrogeco added CCB-READY CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) community and removed CCB-READY labels Mar 31, 2021
@astrogeco
Copy link
Contributor

Thanks for the PR!

@astrogeco astrogeco requested a review from zanzaben April 7, 2021 16:45
@astrogeco
Copy link
Contributor

@zachar1a can you isolate the commit for each fix in it's own PR? You can use git rebase -i or several other methods

Also edit the commit message to follow the standard format You git commit --amend

Fix #{ISSUE_NUMBER}, Short Description

[Optional] Long Description

Thanks for contributing and for being patient as we iron out the kinks in our contribution flows!

@zachar1a
Copy link
Contributor Author

zachar1a commented Apr 7, 2021

@astrogeco I had made a separate branch for each pr. Should I just do one fix at a time?

@zanzaben
Copy link

zanzaben commented Apr 8, 2021

When I run the install command I am getting this error.

/cFS$ pip3 install -e tools/cFS-GroundSystem
Obtaining file:///home/alex/cFS/tools/cFS-GroundSystem
WARNING: No metadata found in ./tools/cFS-GroundSystem
ERROR: Exception:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/pip/_internal/cli/base_command.py", line 186, in _main
status = self.run(options, args)
File "/usr/lib/python3/dist-packages/pip/_internal/commands/install.py", line 357, in run
resolver.resolve(requirement_set)
File "/usr/lib/python3/dist-packages/pip/_internal/legacy_resolve.py", line 177, in resolve
discovered_reqs.extend(self._resolve_one(requirement_set, req))
File "/usr/lib/python3/dist-packages/pip/_internal/legacy_resolve.py", line 333, in _resolve_one
abstract_dist = self._get_abstract_dist_for(req_to_install)
File "/usr/lib/python3/dist-packages/pip/_internal/legacy_resolve.py", line 265, in _get_abstract_dist_for
return self.preparer.prepare_editable_requirement(req)
File "/usr/lib/python3/dist-packages/pip/_internal/operations/prepare.py", line 554, in prepare_editable_requirement
abstract_dist = _get_prepared_distribution(
File "/usr/lib/python3/dist-packages/pip/_internal/operations/prepare.py", line 95, in _get_prepared_distribution
abstract_dist.prepare_distribution_metadata(finder, build_isolation)
File "/usr/lib/python3/dist-packages/pip/_internal/distributions/sdist.py", line 40, in prepare_distribution_metadata
self.req.prepare_metadata()
File "/usr/lib/python3/dist-packages/pip/_internal/req/req_install.py", line 568, in prepare_metadata
self._set_requirement()
File "/usr/lib/python3/dist-packages/pip/_internal/req/req_install.py", line 386, in _set_requirement
if isinstance(parse_version(self.metadata["Version"]), Version):
File "/usr/share/python-wheels/packaging-20.3-py2.py3-none-any.whl/packaging/version.py", line 56, in parse
return Version(version)
File "/usr/share/python-wheels/packaging-20.3-py2.py3-none-any.whl/packaging/version.py", line 275, in init
match = self._regex.search(version)
TypeError: expected string or bytes-like object

@zachar1a
Copy link
Contributor Author

zachar1a commented Apr 8, 2021

Can you still run the tool with python3 /cFS-GroundSystem.py

@zanzaben
Copy link

zanzaben commented Apr 8, 2021

yes, python3 GroundSystem.py still works for me.

@zachar1a
Copy link
Contributor Author

zachar1a commented Apr 8, 2021

Is it possible for you to delete the GroundSystem dir and then reinstall it

@zanzaben
Copy link

zanzaben commented Apr 8, 2021

That fixed it.

@astrogeco astrogeco added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 9, 2021
@astrogeco
Copy link
Contributor

As for the commits and branches. Typically we do one branch per fix and PR so this one is good. The only thing I would change is the capitalization on the "fix" in the message. I'll comment on the other one as well

@zachar1a
Copy link
Contributor Author

Ok I'll be sure to double check it for next time.

@skliper skliper added CCB:2021-04-07 and removed CCB:Approved Indicates approval by CCB labels Apr 14, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate April 21, 2021 13:11
@astrogeco astrogeco merged commit f69c319 into nasa:integration-candidate Apr 21, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 22, 2021
nasa/cFS-GroundSystem#174 update executable name and version in setup.py

nasa/cFS-GroundSystem#175, Add executable install guide
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 22, 2021
Combines:

nasa/cFE#1406
nasa/osal#967
nasa/cFS-GroundSystem#178

Includes:

nasa/cFE#1290, Split interface and implementation modules
nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing
nasa/cFE#1292, Remove testrunner and convert testcase to app
cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert.

nasa/osal#950, Eliminate time and access name collisions with VxWorks
nasa/osal#946, Fix Shell implementation on posix and rtems

nasa/cFS-GroundSystem#174, update executable name and version in setup.py
nasa/cFS-GroundSystem#175, Add executable install guide
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 22, 2021
Combines:

nasa/cFE#1406
nasa/osal#967
nasa/cFS-GroundSystem#178

Includes:

nasa/cFE#1290, Split interface and implementation modules
nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing
nasa/cFE#1292, Remove testrunner and convert testcase to app
cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert.

nasa/osal#950, Eliminate time and access name collisions with VxWorks
nasa/osal#946, Fix Shell implementation on posix and rtems

nasa/cFS-GroundSystem#174, update executable name and version in setup.py
nasa/cFS-GroundSystem#175, Add executable install guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants