Fix #123, create package for cfs-groundsystem

[zachar1a]

Describe the contribution
A clear and concise description of what the contribution is.

• Include explicitly what issue it addresses [e.g. Fixes "start" script or at least make GroundSystem.py executable #123 ]

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

• Behavior Change: (The user will be able to type command 'startg' and start the ground system from anywhere on the system)

System(s) tested on

• OS: [macOS Catalina v 10.15.7]

Additional context
I installed the package with command pip3 install -e relative/path/to/cfs-groundsystem/
In GroundSystem.py there is a variable name ROOTDIR, in order for this command to work, the ROOTDIR has been changed to the path of the file being executed.
The original path was:
ROOTDIR = Path(sys.argv[0]).resolve().parent
and has been changed to:
ROOTDIR = pathlib.Path(file).parent.absolute()

This fix also handles another issue which closes all open windows that spawned from the main process.

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Zachary Christian Gonzalez /none/none

• Else if Individual
  • HAND SIGNED Individual CLA must be on file (once per release): Individual CLA

[lgtm-com]

This pull request introduces 1 alert when merging b386da5 into 10efa70 - view on LGTM.com

new alerts:

• 1 for Unused import

[lgtm-com]

This pull request introduces 1 alert when merging d138a0a into 10efa70 - view on LGTM.com

new alerts:

• 1 for Unused import

[astrogeco]

Hi @zachar1a thank you for your contribution! Could you sign and email the appropriate Contributor License agreement?

• Corporate: https://github.com/nasa/cFE/blob/main/docs/GSC_18128_Corp_CLA_form_1219.pdf
• Individual: https://github.com/nasa/cFE/blob/main/docs/GSC_18128_Ind_CLA_form_1219.pdf

email it to: [email protected] and copy [email protected]

Thanks!

[astrogeco]

Got it!

[zachar1a]

Thank you!

[skliper]

@zachar1a please squash and update commit message to match the following form:

Fix #123, Short Description

Long description (optional)

For this case the title of this PR would be perfect. Marking as CCB:Ignore until this is complete (feel free to remove when ready).

[zachar1a]

I squashed the commits. However I don't believe I am able to change the labels.

[skliper]

@zachar1a Thanks, Looks good. @astrogeco Once reviewed this should be ready for the next round.

[skliper]

@zanzaben - could you also confirm this fixes #121 (and if so link)

[zanzaben]

@zachar1a This isn't working for me on my Ubuntu 20.04.2 LTS machine. The startg command is not found and when I tried running setup.py I got ModuleNotFoundError: No module named 'setuptools'

#121 was fixed and does close all the windows.

[zachar1a]

A requirements file could be added in to help insure the user has a setuptools install but it will just be that in the file.

And yes for the command to appear you will have to use the pip3 install -e path/to/cFS-GroundSystem

[zanzaben]

It is working for me now.

Can you once again squash your commits and add to your description that you are also fixing issue #121.

[zachar1a]

My squash didn’t work correctly, it added another commit instead of combining them. Should I try again or just leave it as is?

[zanzaben]

Try again, it needs to be squashed down to a single commit.

[skliper]

Maybe we could share a couple of our common techniques for squashing? There's the interactive rebase, or a soft reset...

[zachar1a]

I haven't used a soft reset before. But I did try using the interactive rebase this previous time.

[skliper]

Try:

git rebase -i main

and set as

r d672812 Fix #123, create package for cfs-groundsystem Fix #121 close all windows on exit
f af3b10d creating a package for the cfs-groundsystem to be run anywhere on instaalled system with command startg
f dc96b06 Fix #123, create package for cfs-groundsystem
f 9d1b553 fix 123, using a requirements file to insure user has setuptools package needed to install
f 4e64b5e Fix #123, create package for cfs-groundsystem

Then reword the commit to Fix #123, #121, Make into package and close all windows on exit

Or if you want to do the soft reset method, simply:

git reset --soft main
git add -A
git commit -m"Fix #123, #121, Make into package and close all windows on exit"

[zachar1a]

Thank you very much for the information.

[jphickey]

Just use caution with the "soft" method - you need to make sure you reset back to the original baseline. If you've switched branches and pulled from the remote since starting the branch originally, you might inadvertently overwrite other changes.

Yet another method, although a couple more steps, is pretty straightforward, and no chance of inadvertently overwriting other stuff:

• Make a new branch with a new name at the current main (OK if main is newer than where you started).
• Run git merge --squash ${old_branch}
• Check/Test the result and run git commit if good (this lets you write a new commit message summarizing the full change)
• Rename your new branch over your old branch (thereby replacing it): git branch -m -f ${new_branch} ${old_branch}
• Push to github fork as usual

[zachar1a]

Thank you for this it will help out a lot in the future.

[astrogeco]

Rename to "cF-GroundSystem" and update version to use the number in version.py

[astrogeco]

Opening a new issue to add documentation specifically this line:

I installed the package with command pip3 install -e relative/path/to/cfs-groundsystem/