Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #93, Refactor and resolve cast align warning #130

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 31, 2020

Describe the contribution
Fix #93 - replaces old code that caused a cast-align warning when strict

  • refactored and removed unnecessary code while also following recommended model for getaddrinfo.
  • removed old windows support/defines/etc (likely not tested for years, no longer supported).

Testing performed
Built, sent successful command to cFE

Expected behavior changes
No more warning, less fragile.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle main + this commit

Additional context
None.

Third party code
None.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Aug 31, 2020

@hukuzatuna - hopefully solves the SendUdp.c build error.

@skliper skliper added bug Something isn't working CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Aug 31, 2020
@skliper skliper added this to the 2.3.0 milestone Aug 31, 2020
@astrogeco astrogeco added CCB-20200902 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Sep 2, 2020
@astrogeco
Copy link
Contributor

CCB 2020-09-02 APPROVED

@yammajamma yammajamma added CCB:Approved Indicates approval by CCB IC-20200902 and removed CCB:Approved Indicates approval by CCB labels Sep 2, 2020
@yammajamma yammajamma changed the base branch from main to integration-candidate September 2, 2020 19:00
@yammajamma yammajamma merged commit bafd03b into nasa:integration-candidate Sep 3, 2020
@astrogeco astrogeco removed this from the 2.3.0 milestone Jan 27, 2021
@skliper skliper deleted the fix93-strict-align branch February 1, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pointer alignmnet issues on 32 bit ARM
3 participants