Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts executable #7

Closed
skliper opened this issue Jun 24, 2019 · 7 comments · Fixed by #26
Closed

Make scripts executable #7

skliper opened this issue Jun 24, 2019 · 7 comments · Fixed by #26
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Jun 24, 2019

Originated by abrown4 (47 on babelfish) as a general ticket

@skliper skliper added the enhancement New feature or request label Jun 24, 2019
@skliper skliper added this to the 2.1.0 milestone Jun 24, 2019
@skliper skliper added the good first issue Good for newcomers label Jun 24, 2019
@skliper
Copy link
Contributor Author

skliper commented Jun 24, 2019

@avan989
Copy link
Contributor

avan989 commented Aug 26, 2019

Can you clarify? Do you want to make all the python scripts executable or the shell script? Or referring to any scripting files?

@skliper
Copy link
Contributor Author

skliper commented Aug 26, 2019

Only shell scripts (*.sh).

@avan989
Copy link
Contributor

avan989 commented Aug 26, 2019

Only 2 shell scripts, both are already executable:

100755 aa694eed035d9bdf860b2184530ad23db94ac686 0 es-delete-app.sh
100755 972d062c64bc0b7c695cc7c8c9f8251d57b97a77 0 to-enable-tlm.sh

@skliper
Copy link
Contributor Author

skliper commented Aug 26, 2019

Did you already update these and check in? I get them both as 100644.

@skliper
Copy link
Contributor Author

skliper commented Aug 26, 2019

I get 100644 for both after a git pull origin. Strange. Do they show up as changed if you git diff vs master?

@avan989
Copy link
Contributor

avan989 commented Aug 26, 2019 via email

skliper added a commit that referenced this issue Sep 6, 2019
skliper pushed a commit that referenced this issue Sep 6, 2019
skliper added a commit that referenced this issue Sep 6, 2019
Reviewed and approved at 2019-09-04 CCB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants