Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmdUtil is not 64-bit friendly #2

Closed
skliper opened this issue Jun 24, 2019 · 2 comments · Fixed by #92 or #101
Closed

cmdUtil is not 64-bit friendly #2

skliper opened this issue Jun 24, 2019 · 2 comments · Fixed by #92 or #101
Assignees
@skliper
Labels
bug Something isn't working
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Jun 24, 2019 •
edited
Loading

Originated from glimes (45 on babelfish)

As part of our "switch flip" to 64-bit on AOS, we needed to make changes to the cmdUtil program to make it 64-bit clean (the version we had, in at least one place, presumed that "long" was 32 bits).
When I refactored it to clean out the 32/64 dependency, I rerouted all the numeric data encoding through a common function, and ended up eliminating any need for the cmdUtil program to know its own endianness.
@skliper skliper added the enhancement New feature or request label Jun 24, 2019
@avan989
Copy link
Contributor

avan989 commented Aug 29, 2019

Can you clarify what needs to be done?

@skliper skliper mentioned this issue Jan 8, 2020
Closed
@skliper
Copy link
Contributor Author

skliper commented Jan 8, 2020

Real solution is EDS and not a critical short term fix

@skliper skliper mentioned this issue May 21, 2020
Merged
6 tasks
@skliper skliper self-assigned this May 21, 2020
skliper added a commit to skliper/cFS-GroundSystem that referenced this issue May 26, 2020
@skliper
Fix nasa#2, nasa#3, nasa#48, nasa#80, General Upgrade
fa60b5f 
Major rewrite -
Fix nasa#2: Added 64-bit support
Added big endian payload options (use when LE selected to write BE fields)
Fix nasa#3: Added checksum calculation/overide
Added the rest of the override possible fields (for error checking)
Fix nasa#48: Added standard type options (more clear/consistant sizing)
Fix nasa#80: Added cFS Version 2 header support
Added protocol options
Added raw message generation support
Added test script
Added debug and thirtytwo build options
skliper added a commit to skliper/cFS-GroundSystem that referenced this issue May 26, 2020
@skliper
Fix nasa#2, nasa#3, nasa#48, nasa#80, General Upgrade
4d812ea 
Major rewrite -
Fix nasa#2: Added 64-bit support
Added big endian payload options (use when LE selected to write BE fields)
Fix nasa#3: Added checksum calculation/overide
Added the rest of the override possible fields (for error checking)
Fix nasa#48: Added standard type options (more clear/consistant sizing)
Fix nasa#80: Added cFS Version 2 header support
Added protocol options
Added raw message generation support
Added test script
Added debug and thirtytwo build options
skliper added a commit to skliper/cFS-GroundSystem that referenced this issue May 26, 2020
@skliper
Fix nasa#2, nasa#3, nasa#48, nasa#80, General Upgrade
c44cdfd 
Major rewrite -
Fix nasa#2: Added 64-bit support
Added big endian payload options (use when LE selected to write BE fields)
Fix nasa#3: Added checksum calculation/overide
Added the rest of the override possible fields (for error checking)
Fix nasa#48: Added standard type options (more clear/consistant sizing)
Fix nasa#80: Added cFS Version 2 header support
Added protocol options
Added raw message generation support
Added test script
Added debug and thirtytwo build options
skliper added a commit to skliper/cFS-GroundSystem that referenced this issue May 26, 2020
@skliper
Fix nasa#2, nasa#3, nasa#48, nasa#80, General Upgrade
3e62ff8 
Major rewrite -
Fix nasa#2: Added 64-bit support
Added big endian payload options (use when LE selected to write BE fields)
Fix nasa#3: Added checksum calculation/overide
Added the rest of the override possible fields (for error checking)
Fix nasa#48: Added standard type options (more clear/consistant sizing)
Fix nasa#80: Added cFS Version 2 header support
Added protocol options
Added raw message generation support
Added test script
Added debug and thirtytwo build options
@astrogeco astrogeco mentioned this issue Jun 9, 2020
Merged
@astrogeco astrogeco added bug Something isn't working and removed enhancement New feature or request labels Oct 1, 2020
@astrogeco astrogeco added this to the 2.2.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
bug Something isn't working
Projects
None yet
Milestone
Bootes
3 participants
@avan989 @skliper @astrogeco