Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strncpy possibly not null-terminating #128

Closed
CDKnightNASA opened this issue Aug 28, 2020 · 0 comments · Fixed by #129 or #133
Closed

strncpy possibly not null-terminating #128

CDKnightNASA opened this issue Aug 28, 2020 · 0 comments · Fixed by #129 or #133
Milestone
Caelum

Comments

@CDKnightNASA
Copy link
Contributor 

/home/user/nasa/cFS/tools/cFS-GroundSystem/Subsystems/cmdUtil/cmdUtil.c:817:17: error: ‘strncpy’ specified bound 1024 equals destination size [-Werror=stringop-truncation]
                 strncpy(sbuf, &tail[1], sizeof(sbuf));

cFS-GroundSystem/Subsystems/cmdUtil/cmdUtil.c

Line 817 in 5e879b9

strncpy(sbuf, &tail[1], sizeof(sbuf));

CDKnightNASA added a commit to CDKnightNASA/cFS-GroundSystem that referenced this issue Aug 28, 2020
@CDKnightNASA
fix nasa#128 - strncpy should result in null term
da440e7
@CDKnightNASA CDKnightNASA mentioned this issue Aug 28, 2020
Merged
CDKnightNASA added a commit to CDKnightNASA/cFS-GroundSystem that referenced this issue Sep 2, 2020
@CDKnightNASA
fix nasa#128 - strncpy should result in a null term
446179d
yammajamma added a commit that referenced this issue Sep 3, 2020
@yammajamma
Merge pull request #129 from CDKnightNASA/fix-128-strncpy_null_term
ec54b1a 
Fix #128, strncpy should result in null term
@yammajamma yammajamma mentioned this issue Sep 3, 2020
Merged
@astrogeco astrogeco added this to the 2.3.0 milestone Oct 1, 2020
@astrogeco astrogeco modified the milestones: 2.3.0, 3.0.0 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Caelum
2 participants
@CDKnightNASA @astrogeco