Fix #966, update padding in CDS registry struct #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put all ES typedefs which are shared across API and telemetry messages into the "cfe_es_extern_typedefs.h" file. Put all ES typedefs which define the telemetry interface into the "cfe_es_msg.h" file. Also include structures which define the output of commands that write data files into this group (query all apps, query all tasks, query all CDS). Removes some localized definitions and replace with MISSION scope definitions where appropriate/necessary.
jphickey
force-pushed
the
fix-966-update-padding
branch
from
038fb9b
to
5cd7ffc
Compare
As the name field is a multiple of 4 bytes, there needs to be 3 bytes of padding, not 1, to avoid implicit padding. This doesn't change anything, it just makes the padding explicit instead of implicit.
jphickey
force-pushed
the
fix-966-update-padding
branch
from
5cd7ffc
to
d21d94a
Compare
jphickey
added
the
CCB:Ready
skliper
approved these changes
Oct 27, 2020
|
@skliper and @astrogeco on second thought should I just add this commit to #964 instead, since the dependent commit hasn't been merged yet? I can push the commit to the other PR and close this PR - might avoid a merge issue later. |
|
Whichever approach you prefer is fine by me. |
|
Moved to PR #964 because I wanted to fix the name too - having all in a single PR simplifies merging. |
astrogeco
added
invalid
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Makes the 3 bytes of padding here explicit rather than implicit.
Testing performed
Build and sanity check CFE
Issued CFE_ES_DUMP_CDS_REGISTRY_CC command and ensure it is working as expected
Expected behavior changes
None
System(s) tested on
Ubuntu 20.04
Additional Context
Depends on the previous change for #909 ( PR #964 )
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.