Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #890, CFE_ES_CalculateCRC default stub behavior #892

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 21, 2020

Describe the contribution
Fix #890 - CFE_ES_CalculateCRC updated to default return behavior.

Testing performed
Built and ran unit tests, passed.

Expected behavior changes
Now setting the return code (and deferred return code) works for CFE_ES_CalculateCRC.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle main + this commit.

Additional context
None.

Third party code
None.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added CCB:FastTrack CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Sep 21, 2020
@skliper skliper added this to the 7.0.0 milestone Sep 21, 2020
@skliper
Copy link
Contributor Author

skliper commented Sep 21, 2020

@jiajlin - Does this work for you?

@yammajamma yammajamma added CCB-20200923 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Sep 24, 2020
@yammajamma yammajamma changed the base branch from main to integration-candidate September 24, 2020 12:48
@yammajamma yammajamma merged commit a713784 into nasa:integration-candidate Sep 24, 2020
@skliper skliper deleted the fix890-calccrc-rtn-stub branch February 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set return code of CFE_ES_CalculateCRC using UT_SetDeferredRetcode
2 participants