Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #797, refactor internal table/id management #859

Merged
merged 6 commits into from
Sep 4, 2020
Merged

Fix #797, refactor internal table/id management #859

merged 6 commits into from
Sep 4, 2020

Commits on Sep 2, 2020

  1. Fix nasa#797, refactor internal table/id management in ES 

    Introduce wrapper/accessor functions to look up table
entries by ID for Executive Services subsystem.

__Do not use AppID as a table index__.

Note - This does not change existing external APIs and AppIDs
are still zero-based uint32.  This only changes the internal
structures to remove use of ID as an array index, and to use a lookup
function to locate the table entry from an ID.  All entry access
is then performed via the table entry pointer, rather than
as an array index.

This provides the groundwork for abstract IDs without actually
changing anything fundamental about resource IDs.
    @jphickey
    jphickey committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    4d3c809 View commit details
    Browse the repository at this point in the history

  2. Fix nasa#797, refactor internal table/id management in EVS 

    Update the EVS subsystem to follow the ES pattern for
internal table management.

Do not use AppID directly as a table index.  Instead,
use a separate lookup routine to get a pointer to the
entry, then access the entry via the pointer.

Also introduce inline helper functions to get/set
status of entry (free/not free), etc.
    @jphickey
    jphickey committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    2efe70b View commit details
    Browse the repository at this point in the history

  3. Fix nasa#797, Update FS subsystem for abstract IDs 

    Minor fixup for use of IDs when logging
    @jphickey
    jphickey committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    dfe8abc View commit details
    Browse the repository at this point in the history

  4. Fix nasa#797, Update SB subsystem for abstract IDs 

    Change SB to get its task ID from ES rather than getting
it directly from OSAL.  Update syslog calls to use the
ES-supplied conversion to integer rather than direct cast.
    @jphickey
    jphickey committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    4d901e8 View commit details
    Browse the repository at this point in the history

  5. Fix nasa#797, Update TBL subsystem for abstract IDs 

    Update TBL to use the new ES-supplied ID manipulations.  Update
all syslog calls to convert to integer using ES wrapper.
    @jphickey
    jphickey committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    aa8d7a9 View commit details
    Browse the repository at this point in the history

  6. Fix nasa#797, Update TIME subsystem for abstract IDs 

    Update the TIME subsystem to use the new ES-supplied ID
abstractions.  Do not use AppID directly as array index
when registering sync callbacks, use the ES-supplied
conversion to array index before accessing local table.

Also update logging to use ES-supplied conversion
    @jphickey
    jphickey committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    7f0c08e View commit details
    Browse the repository at this point in the history