Fix #778, Add CFE_Assert library and test module #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides ability to load UT assert as a CFE app, and an example of using this to test some basic CFE ES functions. This introduces a separate library for the basic UT assert functions (cfe_assert) and an app that executes the test (cfe_testrunner) rather than combining these into a single module.
astrogeco
added
IC-20200812
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Provides ability to load UT assert as a CFE app, and an example of using this to test some basic CFE ES functions.
This introduces a separate library for the basic UT assert functions (cfe_assert) and an app that executes the test (cfe_testrunner) rather than combining these into a single module.
Fixes #778
Also adds a small "howto" document to provide an example of the lines that need to be added to
cfe_es_startup.scrto make this run, and document the dependencies between these modules.Testing performed
Build and run CFE, confirm tests execute and pass.
Expected behavior changes
Implements functional test framework (same as PR #779)
System(s) tested on
Ubuntu 20.04
Additional context
This replaces my original PR #779 - which had the same but as a single
cfe_assertapp. The problem with this was that it didn't guarantee the init routine completed before the subsequent test cases were loaded, because app init is run in a separate thread, where as lib init is run synchronously within the main startup thread.This approach requires two entries in the startup script rather than one, but does ensure that the init is race-free.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.