Fix #679, Alignment warnings in unit test #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only commit for PR/review here is 0037fc0. Created as draft due to baseline mismatch. |
skliper
approved these changes
May 8, 2020
|
CCB 20200513 - Approved conceptually, needs rebase |
Resolve remaining alignment warnings in the unit test and stub code. In es_UT.c test cases were passing a char* as a stack pointer (uint32*) Memory pool code was also using uint8[] buffer as uint32. Most casting becomes unnecessary when defined as the correct type.
jphickey
force-pushed
the
fix-679-ut-alignment-warnings
branch
from
0037fc0
to
744a9b4
Compare
|
@jphickey is this ready to merge? |
astrogeco
added
CCB:Approved
|
Correction - thought this one was the other commit .... |
astrogeco
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Resolve remaining alignment warnings in the unit test and stub code.
Testing performed
Build with ENABLE_UNIT_TESTS=true for native arch and a cross target with strict alignment requirements.
confirm no warnings on either build, all unit tests pass.
Expected behavior changes
No compiler warnings or errors on cross build.
System(s) tested on
Ubuntu 20.04 (host, little endian, 64-bit, lax alignment)
MIPS via QEMU (cross target, big endian, 32-bit, strict alignment)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.