-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #687, validate table handle prior to use #688
Merged
astrogeco
merged 1 commit into
nasa:integration-candidate
from
CDKnightNASA:fix-687-tblhandle_verify
May 19, 2020
Merged
Fix #687, validate table handle prior to use #688
astrogeco
merged 1 commit into
nasa:integration-candidate
from
CDKnightNASA:fix-687-tblhandle_verify
May 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDKnightNASA
added
the
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
label
May 7, 2020
skliper
approved these changes
May 7, 2020
Squash these (just don't assign NULL):
|
jphickey
previously requested changes
May 7, 2020
CDKnightNASA
force-pushed
the
fix-687-tblhandle_verify
branch
from
May 7, 2020 19:23
4326e5d
to
69cd57b
Compare
updated, squashed, pushed, better? :) |
skliper
approved these changes
May 7, 2020
jphickey
reviewed
May 7, 2020
CDKnightNASA
force-pushed
the
fix-687-tblhandle_verify
branch
from
May 7, 2020 21:36
69cd57b
to
84809a7
Compare
astrogeco
changed the title
fix #687 - validate table handle prior to use
Fix #687 - validate table handle prior to use
May 13, 2020
astrogeco
changed the title
Fix #687 - validate table handle prior to use
Fix #687, validate table handle prior to use
May 13, 2020
skliper
added
CCB-20200513
enhancement
and removed
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
labels
May 13, 2020
CCB 20200513 - Approved |
astrogeco
added
CCB:Approved
Indicates code review and approval by community CCB
IC-20200513
labels
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
fixes a bug where a table handle is used prior to validation (used in the variable initialization at the top of CFE_TBL_Load() .)
Fix #687
Contributor Info - All information REQUIRED for consideration of pull request
[email protected]