Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #681, Resolve doxygen warnings for tbl #686

Merged
merged 1 commit into from
May 19, 2020
Merged

Fix #681, Resolve doxygen warnings for tbl #686

merged 1 commit into from
May 19, 2020

Conversation

CDKnightNASA
Copy link
Contributor

@CDKnightNASA CDKnightNASA commented May 7, 2020 •
edited by skliper
Loading

Describe the contribution
Fixes doxygen warnings for the tbl subsystem.

Fix #681

Testing performed
make doc, grep "TBL" build/doc/warnings.log

Contributor Info - All information REQUIRED for consideration of pull request
[email protected]

skliper
skliper approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but may need rebase once #648 is in

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 7, 2020
@skliper skliper added this to the 6.8.0 milestone May 7, 2020
@skliper skliper added the docs This change only affects documentation. label May 7, 2020
@CDKnightNASA
Copy link
Contributor Author

Looks fine, but may need rebase once #648 is in

copy, removed cfe_tbl_task_cmds.h from this pull request

@lbleier-GSFC lbleier-GSFC mentioned this pull request May 8, 2020
Merged
@skliper skliper changed the title fix #681 - corrected doxygen for tbl Fix #681, Resolve doxygen warnings for tbl May 8, 2020
@skliper skliper added CCB-20200613 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 13, 2020
@skliper
Copy link
Contributor

skliper commented May 13, 2020

CCB 20200513 - Approved

@astrogeco astrogeco changed the base branch from master to integration-candidate May 19, 2020 20:08
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB IC-20200513 labels May 19, 2020
@astrogeco astrogeco merged commit c72b0ba into nasa:integration-candidate May 19, 2020
@astrogeco astrogeco mentioned this pull request May 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation.
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Doxygen warnings
3 participants
@CDKnightNASA @skliper @astrogeco