Fix #637, Remove old CFE_ARINC653-related tests #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
approved these changes
Apr 27, 2020
skliper
added
the
CCB:Ready
|
CLA receipt confirmed |
|
CCB 2020-04-29 : APPROVED |
astrogeco
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #637
Removes all conditional preprocessing blocks related to CFE_ARINC653.
(Only used in
fsw/cfe-core/unit-test/es_UT.candfsw/cfe-core/unit-test/es_UT.h).Testing performed
Steps taken to test the contribution:
SIMULATION=native,ENABLE_UNIT_TESTS=true,OMIT_DEPRECATEDset tofalsethentrue,BUILDTYPE=debugAll unit tests passed. No errors reported by cFS executable.
Expected behavior changes
None
System(s) tested on
Additional context
Also successfully built using custom Docker images (CentOS 7, Ubuntu 18.04, and Ubuntu 20.04) implementing the standard build procedure. In this context, different combinations of
OMIT_DEPRECATEDandBUILDTYPEwere used. No errors reported by cFS executable.Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Guillaume Lethuillier
Personal, individual CLA submitted