Fix #24 #355, Add compile flag abstractions #457
Conversation
There was a problem hiding this comment.
The change seems OK for CI but I am not sure we should necessarily put this type of thing into the example file that we suggest projects base their build off of.
It has been also discussed to set up CI to test multiple different configurations. If we had that feature then this extra flag logic could be confined to those CI-specific test configs, keeping the example version cleaner/simpler.
|
Preference is for complexity to be shifted to the build system vs CI to simplify user's burden to execute similar tests locally (and adapt the sample as needed). Our CI has external dependencies that the build system doesn't have, if a user want's to try out the examples it's trivial and obvious when provided as part of the build system (just flags to prep). |
|
Understood, but CI needs to be more extensive anyway, because it currently does not sufficiently cover the compile-time options available. This has been discussed in the past and also I believe there are some related tickets to test with different configs. My suggestion is to make more than one "defs" directory here, so the The other "defs" directories can be used during CI as well as examples of more complex configs. But the main issue is the logic being proposed is something very CI-specific, and absolutely NOT a good example of the right way to do things. |
|
CCB - 20200108: discussed compiler flags in depth, scoping for mission/host vs target would improve things, Joe will submit an update |
Adds STRICT_NO_WARNINGS and OMIT_DEPRECATED prep options for CI and as example build
skliper
force-pushed
the
fix24a355-compile-flags
branch
from
69a7930
to
28c6d80
Compare
|
Took a shot at better scoping, and applied by default. Note this just defines HOST_STRICT_COMPILE and TARGET_STRICT_COMPILE, the add_definitions would need to go in the appropriate locations. |
Describe the contribution
Fixes #24, Fixes #355
Adds STRICT_NO_WARNINGS and OMIT_DEPRECATED
prep options for CI and as example build
Testing performed
Built with STRICT_NO_WARNINGS=true, false, and undefined
Built with OMIT_DEPRECATED=true, false, and undefined (note sample_app fails)
Confirmed flags get globally applied (not great scoping, but ensures flag coverage)
Expected behavior changes
Simplifies/enables CI based on abstracted flags, see nasa/cFS#39
System(s) tested on:
Contributor Info
Jacob Hageman - NASA/GSFC