Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2556, flight like platformed defined values #2557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmknutsen
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Updates CFE_PLATFORM_EVS_LOG_MAX and CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC to align with 'flight like' values

Testing performed
CI pipeline
BVT testing

System(s) tested on

  • Ubuntu 20.04
  • cFE Development Build equuleus-rc1+dev131 (Codename Equuleus), Last Official Release: cFE v6.7.0)

Contributor Info - All information REQUIRED for consideration of pull request
Dan Knutsen
NASA Goddard

@skliper
Copy link
Contributor

skliper commented May 9, 2024

Might be a surprise to anyone using the defaults? Is there a way to match the BVTs w/o open source behavior changes?

@dmknutsen
Copy link
Contributor Author

dmknutsen commented May 9, 2024

Yep - we could just put the updates in the example_platform_cfg.h (and change the name as part of the test setup). I'm a bit surprised that the functional tests failed, as I just changed CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC back to it's original value that I was thinking was more flight like. The only reason we changed it in the first place was to prevent test results from being squelched in the console output (cfe_test.log has always been correct). In any case, just using example_platform_cfg.h fixes both issues...I'll push an update.

@dzbaker
Copy link
Collaborator

dzbaker commented Sep 12, 2024

@dmknutsen Would you be able to go over this one at next week's CCB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update platform defined values to be more 'flight like'/work with BVT tests
4 participants