Fix #2553, null value in vsnprintf #2554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2553, fix test that was passing null value
into vsnprintf
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Fixes #2553, address issue that occur when running with address sanitizer. One of the coverage test was trying to pass an
null value to force an return code of 0 or less to an vsnprintf. Passing an null value as an input is an undefine behavior but you can achieve the same result by passing in an empty string which will force the return code to be 0.
Testing performed
Steps taken to test the contribution:
add the following options:
add_compile_options(-fsanitize=address -g)
add_link_options(-fsanitize=address)
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
no more error when running with fsanitize.
Still 100% coverage.
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Anh Van, GSFC