Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2538, table transaction initial implementation #2539

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Initial implementation of transaction concept for table API calls. The basic transaction object wraps all of the relevant pointers and state information for the request being processed.

Fixes #2538

Testing performed
Build and run all tests

Expected behavior changes
Internal code structure more manageable.
Behavior of external/public API calls should remain the same.

System(s) tested on
Debian

Additional context
Does not really "fix" the problem of race conditions alone, needs more work to actually move/reorg the problem areas. But this doesn't break anything that wasn't already broken (i.e. race conditions in here were there before). They are just more evident (and fixable) now.

Unit and functional tests (mostly) did not need to change for this, aside from a few minor details.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 28, 2024
@jphickey
Copy link
Contributor Author

Still need to do some documentation updates on this PR. Will follow up with an update. Expecting the documentation-related workflow(s) to fail on this for now.

@jphickey jphickey force-pushed the fix-2538-tbl-transaction branch 4 times, most recently from 2eddc7b to 17504c4 Compare March 28, 2024 17:55
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Initial implementation of transaction concept for table API calls.
The basic transaction object wraps all of the relevant pointers
and state information for the request being processed.
@jphickey
Copy link
Contributor Author

Documentation updates should be resolved now, pending successful workflow run.

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Mar 28, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Mar 28, 2024
*Combines:*

cFE equuleus-rc1+dev120
osal equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2535
- nasa/cFE#2539

*osal*
- nasa/osal#1350

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
jphickey added a commit that referenced this pull request Apr 1, 2024
Correct warnings about uninitialized values
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 1, 2024
*Combines:*

cFE equuleus-rc1+dev120
osal equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2535
- nasa/cFE#2539

*osal*
- nasa/osal#1350

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@dzbaker dzbaker merged commit bdba608 into nasa:main Apr 1, 2024
22 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 1, 2024
*Combines:*

cFE equuleus-rc1+dev120
osal equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2535
- nasa/cFE#2539

*osal*
- nasa/osal#1350

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@jphickey jphickey deleted the fix-2538-tbl-transaction branch April 5, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce transaction object for CFE TBL
2 participants