-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2538, table transaction initial implementation #2539
Conversation
Still need to do some documentation updates on this PR. Will follow up with an update. Expecting the documentation-related workflow(s) to fail on this for now. |
2eddc7b
to
17504c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Initial implementation of transaction concept for table API calls. The basic transaction object wraps all of the relevant pointers and state information for the request being processed.
17504c4
to
0604676
Compare
Documentation updates should be resolved now, pending successful workflow run. |
*Combines:* cFE equuleus-rc1+dev120 osal equuleus-rc1+dev62 **Includes:** *cFE* - nasa/cFE#2535 - nasa/cFE#2539 *osal* - nasa/osal#1350 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
Correct warnings about uninitialized values
*Combines:* cFE equuleus-rc1+dev120 osal equuleus-rc1+dev62 **Includes:** *cFE* - nasa/cFE#2535 - nasa/cFE#2539 *osal* - nasa/osal#1350 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
*Combines:* cFE equuleus-rc1+dev120 osal equuleus-rc1+dev62 **Includes:** *cFE* - nasa/cFE#2535 - nasa/cFE#2539 *osal* - nasa/osal#1350 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
Checklist (Please check before submitting)
Describe the contribution
Initial implementation of transaction concept for table API calls. The basic transaction object wraps all of the relevant pointers and state information for the request being processed.
Fixes #2538
Testing performed
Build and run all tests
Expected behavior changes
Internal code structure more manageable.
Behavior of external/public API calls should remain the same.
System(s) tested on
Debian
Additional context
Does not really "fix" the problem of race conditions alone, needs more work to actually move/reorg the problem areas. But this doesn't break anything that wasn't already broken (i.e. race conditions in here were there before). They are just more evident (and fixable) now.
Unit and functional tests (mostly) did not need to change for this, aside from a few minor details.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.