Fix #2561, send CMake message to stdout instead of stderr #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codym48
changed the title
|
FYI @jphickey as the last developer that touched this line |
dzbaker
added
the
CCB:Approved
This was referenced May 21, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 21, 2024
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 PSP equuleus-rc1+dev42 to_lab equuleus-rc1+dev56 **Includes:** *cFS* - #751 - #762 *cFE* - nasa/cFE#2537 - nasa/cFE#2525 *osal* - nasa/osal#1460 *PSP* - nasa/PSP#430 *to_lab* - nasa/to_lab#198 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Cody Martin <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 21, 2024
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 PSP equuleus-rc1+dev42 to_lab equuleus-rc1+dev56 **Includes:** *cFS* - #751 - #762 *cFE* - nasa/cFE#2537 - nasa/cFE#2525 *osal* - nasa/osal#1460 *PSP* - nasa/PSP#430 *to_lab* - nasa/to_lab#198 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Cody Martin <[email protected]> Co-authored by: Dan Knutsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fix #2561.
While executing the drac0-rc5 training exercises, I noticed on the first
make prepcall that the following message is printed to stderrThis seems like an informational message that would be more appropriate for stdout than stderr, so I added the
STATUSkeyword to the cmakemessagecall.Testing performed
Before change
After change
Expected behavior changes
System(s) tested on
Additional context
This is a bit of a trial balloon to feel out the cFS contribution process. I won't be offended if you close this Pull Request with no action. Thank you for your hard work on this product and its outstanding documentation!
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)