Fix #2436, Adds an empty string or null pointer check for pipe creation #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
force-pushed
the
add_emptyString_check
branch
2 times, most recently
from
3891875
to
a650f2b
Compare
chillfig
force-pushed
the
add_emptyString_check
branch
4 times, most recently
from
e66ab7b
to
53ca0df
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chillfig
force-pushed
the
add_emptyString_check
branch
2 times, most recently
from
bb0959b
to
ad75d48
Compare
jphickey
reviewed
Sep 29, 2023
chillfig
force-pushed
the
add_emptyString_check
branch
from
ad75d48
to
a0311d7
Compare
chillfig
force-pushed
the
add_emptyString_check
branch
from
a0311d7
to
e78a7be
Compare
chillfig
added
the
CCB:Ready
chillfig
force-pushed
the
add_emptyString_check
branch
from
e78a7be
to
27e6b24
Compare
dzbaker
added
CCB:Approved
dzbaker
added a commit
that referenced
this pull request
Oct 5, 2023
Fix #2436, Adds an empty string or null pointer check for pipe creation
2 tasks
chillfig
force-pushed
the
add_emptyString_check
branch
from
27e6b24
to
f1918c6
Compare
chillfig
force-pushed
the
add_emptyString_check
branch
from
f1918c6
to
58551ac
Compare
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 12, 2023
*Combines:* cFE v7.0.0-rc4+dev395 osal v6.0.0-rc4+dev239 **Includes:** *cFE* - nasa/cFE#2440 - nasa/cFE#2450 *osal* - nasa/osal#1422 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 12, 2023
*Combines:* cFE v7.0.0-rc4+dev395 osal v6.0.0-rc4+dev239 **Includes:** *cFE* - nasa/cFE#2440 - nasa/cFE#2450 *osal* - nasa/osal#1422 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
-Fixes #2436
Testing performed
build, functional test
Expected behavior changes
Assigns
CFE_SB_BAD_ARGUMENTto Status when empty string are passed in for thePipeNameSystem(s) tested on
Additional context
I added a check for PipeName != NULL. This is to ensure that PipeName is not a NULL pointer, which would cause a segmentation fault when attempting to dereference it with PipeName[0].
This empty string check can potentially be performed at a lower level that processes PipeName at time of pipe creation: https://github.com/nasa/osal/blob/b5dd01c91f22ea913b0b87658ec5038c6de5275e/src/os/shared/src/osapi-idmap.c#L1168
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems