Fix #1991, TriggerMode unsigned compare with 0 #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Killelea <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
This allows removal of cpp-check warning suppression and fixes a CodeSonar static analysis warning.
Note CFE_ES_PERF_TRIGGER_START is 0 here:
cFE/modules/es/fsw/src/cfe_es_perf.h
Line 54 in f6d7f8c
and TriggerMode is uint32 here:
cFE/modules/es/config/default_cfe_es_msgstruct.h
Line 279 in f6d7f8c
So the check is always true. Only useful validity check is < CFE_ES_PERF_MAX_MODES.
Testing performed
CI
Expected behavior changes
None
System(s) tested on
CI
Additional context
Doesn't actually impact code coverage since it looks like this check was getting compiled out anyways.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC