Fix #2335, generalize update header parameter #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Expand the "Increment Sequence" boolean on transmit message functions to be a more general "Update Header" boolean, so it can be used for other fields like timestamps, checksums, or user-defined fields too.
jphickey
force-pushed
the
fix-2335-update-header
branch
from
c13e761
to
393a015
Compare
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 22, 2023
*Combines:* cFE v7.0.0-rc4+dev318 sch_lab v2.5.0-rc4+dev57 **Includes:** *cFE* - nasa/cFE#2336 - nasa/cFE#2338 *sch_lab* - nasa/sch_lab#145 Co-authored by: Daniel Knutsen <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 22, 2023
*Combines:* cFE v7.0.0-rc4+dev318 sch_lab v2.5.0-rc4+dev57 **Includes:** *cFE* - nasa/cFE#2336 - nasa/cFE#2338 *sch_lab* - nasa/sch_lab#144 Co-authored by: Daniel Knutsen <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Expand the "Increment Sequence" boolean on transmit message functions to be a more general "Update Header" boolean, so it can be used for other fields like timestamps, checksums, or user-defined fields too.
Fixes #2335
Fixes #1157
Testing performed
Build and run CFE, sanity check, confirm headers are as expected
Expected behavior changes
Headers will be updated more consistently/generically.
Note -- Messages classified as Commands will have headers updated, too - specifically the sequence count and checksum. This will apply to messages being created by SCH/SCH_LAB, and the time signals sent by CFE TIME. Previously the sequence counter was not set in any of these messages, so it would have always been zero. Hence receivers would not be relying on it for anything, and thus setting it nonzero shouldn't break anything, either. But there is a slight chance that some code had a dependency on this always being zero.
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.