Fix #1473, Add helper for CFE_SB_Write...InfoCmd()
with common logic
#2285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_SB_Write*InfoCmd
to implement common logic #1473CFE_SB_Write*InfoCmd()
functions into a helper function to reduce code duplication.The 3 different commands now call
CFE_SB_WriteInfo()
with their personalised input parameters to perform the actual write. (I was considering naming the new functionCFE_SB_PerformWriteInfoCmd()
).Testing performed
GitHub CI actions all passing successfully.
Local testing shows net coverage (for the full cFS bundle) is unaffected and the changes result in a net reduction of 22 lines and 12 branches.
Before the changes:
After the changes:
Expected behavior changes
No change to behavior.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt