Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1456, Rename CFE_SB_RemovePipeCallback_t to ...backArgs_t #2189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 27, 2022

Checklist

Describe the contribution

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No impact on behavior.

Contributor Info
Avi Weiss @thnkslprpt

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but also something we should consider documenting in https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md as well (given that names are almost always subjective, if we are going to be doing PRs to fix names then we should have something to fall back on that says what is "right")

@thnkslprpt
Copy link
Contributor Author

Looks good, but also something we should consider documenting in https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md as well (given that names are almost always subjective, if we are going to be doing PRs to fix names then we should have something to fall back on that says what is "right")

Good point - I forgot to update that doc. Will do so today.

@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@thnkslprpt thnkslprpt force-pushed the fix-1456-rename-CFE_SB_RemovePipeCallback_t branch from e15a797 to ee2bd99 Compare April 19, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE_SB_RemovePipeCallback_t typedef implies a callback, but it's callback arguments
3 participants