-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOTFIX #2066: Revert changes to versioning information #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrogeco
force-pushed
the
standardize-version.h
branch
2 times, most recently
from
March 24, 2022 21:12
4b383e0
to
da399f3
Compare
astrogeco
commented
Mar 24, 2022
astrogeco
force-pushed
the
standardize-version.h
branch
from
March 24, 2022 22:16
da399f3
to
f935ade
Compare
skliper
reviewed
Mar 24, 2022
astrogeco
force-pushed
the
standardize-version.h
branch
from
March 24, 2022 22:19
f935ade
to
cec1d1d
Compare
skliper
reviewed
Mar 24, 2022
*/ | ||
#define CFE_MISSION_REV 0 | ||
#define CFE_MISSION_REV 0xFF | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-254 you mean? 0 and 255 we've claimed. You could just reference the issue? Not sure how helpful that is though.
astrogeco
commented
Mar 24, 2022
astrogeco
force-pushed
the
standardize-version.h
branch
2 times, most recently
from
March 24, 2022 22:32
697ad0a
to
fcbabc3
Compare
astrogeco
added a commit
that referenced
this pull request
Mar 25, 2022
HOTFIX: Revert changes to versioning information
astrogeco
force-pushed
the
standardize-version.h
branch
2 times, most recently
from
March 25, 2022 19:28
aa7724a
to
cf698a1
Compare
astrogeco
changed the title
HOTFIX: Revert changes to versioning information
HOTFIX #2066: Revert changes to versioning information
Mar 25, 2022
astrogeco
added a commit
that referenced
this pull request
Mar 25, 2022
HOTFIX #2066: Revert changes to versioning information
Add link to cfs_versions.dox for documentation Add note on CFE_MISSION_REV status (nasa/cFS#440)
astrogeco
force-pushed
the
standardize-version.h
branch
from
March 25, 2022 19:50
cf698a1
to
36716fb
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 25, 2022
**Combines** nasa/cFE#2074, v7.0.0-rc4+dev94 nasa/osal#1239, v6.0.0-rc4+dev66 nasa/PSP#330, v1.6.0-rc4+dev21 nasa/ci_lab#107, v2.5.0-rc4+dev17 nasa/sample_app#171, v1.3.0-rc4+dev16 nasa/sample_lib#80, v1.3.0-rc4+dev16 nasa/to_lab#119, v2.5.0-rc4+dev16 nasa/sch_lab#112, v2.5.0-rc4+dev23 **Includes** *Standardize Version Information* nasa/cFE#2071 nasa/osal#1240 nasa/PSP#329 nasa/sample_app#170 nasa/sample_lib#79 nasa/ci_lab#108 nasa/to_lab#118 nasa/sch_lab#111 *Update Copyright Headers* nasa/PSP#328 nasa/sample_app#169 nasa/sample_lib#78 nasa/ci_lab#106 nasa/to_lab#117 nasa/sch_lab#110
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 25, 2022
**Combines** nasa/cFE#2074, v7.0.0-rc4+dev94 nasa/osal#1239, v6.0.0-rc4+dev66 nasa/PSP#330, v1.6.0-rc4+dev21 nasa/ci_lab#107, v2.5.0-rc4+dev17 nasa/sample_app#171, v1.3.0-rc4+dev16 nasa/sample_lib#80, v1.3.0-rc4+dev16 nasa/to_lab#119, v2.5.0-rc4+dev16 nasa/sch_lab#112, v2.5.0-rc4+dev23 nasa/elf2cfetbl#108, v3.3.0-rc4+dev18 **Includes** *Standardize Version Information* nasa/cFE#2071 nasa/osal#1240 nasa/PSP#329 nasa/sample_app#170 nasa/sample_lib#79 nasa/ci_lab#108 nasa/to_lab#118 nasa/sch_lab#111 nasa/elf2cfetbl#107 *Update Copyright Headers* nasa/PSP#328 nasa/sample_app#169 nasa/sample_lib#78 nasa/ci_lab#106 nasa/to_lab#117 nasa/sch_lab#110 nasa/elf2cfetbl#106
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 25, 2022
**Combines** nasa/cFE#2074, v7.0.0-rc4+dev94 nasa/osal#1239, v6.0.0-rc4+dev66 nasa/PSP#330, v1.6.0-rc4+dev21 nasa/ci_lab#107, v2.5.0-rc4+dev17 nasa/sample_app#171, v1.3.0-rc4+dev16 nasa/sample_lib#80, v1.3.0-rc4+dev16 nasa/to_lab#119, v2.5.0-rc4+dev16 nasa/sch_lab#112, v2.5.0-rc4+dev23 nasa/elf2cfetbl#108, v3.3.0-rc4+dev18 nasa/tblCRCTool#67, v1.3.0-rc4+dev14 nasa/cFS-GroundSystem#209, v3.0.0-rc4+dev19 **Includes** *Standardize Version Information* nasa/cFE#2071 nasa/osal#1240 nasa/PSP#329 nasa/sample_app#170 nasa/sample_lib#79 nasa/ci_lab#108 nasa/to_lab#118 nasa/sch_lab#111 nasa/elf2cfetbl#107 nasa/tblCRCTool#66 nasa/cFS-GroundSystem#210 *Update Copyright Headers* nasa/cFE#2070 nasa/osal#1236 nasa/PSP#328 nasa/sample_app#169 nasa/sample_lib#78 nasa/ci_lab#106 nasa/to_lab#117 nasa/sch_lab#110 nasa/elf2cfetbl#106 nasa/tblCRCTool#65 nasa/cFS-GroundSystem#208 Co-authored-by: Jacob Hageman <[email protected]>
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 25, 2022
**Combines** nasa/cFE#2074, v7.0.0-rc4+dev94 nasa/osal#1239, v6.0.0-rc4+dev66 nasa/PSP#330, v1.6.0-rc4+dev21 nasa/ci_lab#107, v2.5.0-rc4+dev17 nasa/sample_app#171, v1.3.0-rc4+dev16 nasa/sample_lib#80, v1.3.0-rc4+dev16 nasa/to_lab#119, v2.5.0-rc4+dev16 nasa/sch_lab#112, v2.5.0-rc4+dev23 nasa/elf2cfetbl#108, v3.3.0-rc4+dev18 nasa/tblCRCTool#67, v1.3.0-rc4+dev14 nasa/cFS-GroundSystem#209, v3.0.0-rc4+dev19 **Includes** *Standardize Version Information* nasa/cFE#2071 nasa/osal#1240 nasa/PSP#329 nasa/sample_app#170 nasa/sample_lib#79 nasa/ci_lab#108 nasa/to_lab#118 nasa/sch_lab#111 nasa/elf2cfetbl#107 nasa/tblCRCTool#66 nasa/cFS-GroundSystem#210 *Update Copyright Headers* nasa/cFE#2070 nasa/osal#1236 nasa/PSP#328 nasa/sample_app#169 nasa/sample_lib#78 nasa/ci_lab#106 nasa/to_lab#117 nasa/sch_lab#110 nasa/elf2cfetbl#106 nasa/tblCRCTool#65 nasa/cFS-GroundSystem#208 Co-authored-by: Jacob Hageman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Per conversation in CCB:2022-03-24 and in e5be061#commitcomment-69358417
Ensuring REVISION number is set to 99
Correct cfs_versions.dox appropriately.
Testing performed
Text and documentation only
Expected behavior changes
No behavior change
System(s) tested on
n/a
Additional context
e5be061#commitcomment-69358417
Third party code
none
Contributor Info - All information REQUIRED for consideration of pull request
Gerardo E. Cruz-Ortiz, NASA