Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1982, extended header definitions and test updates #1983

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Do not double-typedef the CFE_MSG types when using extended headers.
This also corrects a call to UT_SetForceFail in the extended header test, which was renamed.

Fixes #1982

Testing performed
Build and run all CFE sanity checks, with extended headers enabled.

Expected behavior changes
Builds and runs correctly when extended headers are selected.

System(s) tested on
Ubuntu

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Do not double-typedef the CFE_MSG types when using extended headers.
This also corrects a call to UT_SetForceFail in the extended
header test, which was renamed.
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 29, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Sep 29, 2021
@astrogeco astrogeco requested a review from skliper September 29, 2021 16:04
@astrogeco
Copy link
Contributor

astrogeco commented Sep 29, 2021

https://github.com/nasa/cFS/wiki/Community-CCB-Agenda:-September-29-2021 APPROVED

  • How do we catch these in the future?
    • Check CI config that uses extended headers
  • What do we with things that are "broken" in Caelum but work for some stakeholders?

@astrogeco astrogeco changed the base branch from main to integration-candidate October 6, 2021 14:20
@astrogeco astrogeco merged commit e8ebaac into nasa:integration-candidate Oct 6, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Oct 6, 2021
nasa/cFE##1989

Includes:

nasa/cFE#1978, Grammatical cleanup of requirements

nasa/cFE#1983, Build errors when using extended headers
astrogeco added a commit to nasa/cFS that referenced this pull request Oct 18, 2021
nasa/cFE#1989, v6.8.0-rc1+dev1030

Includes:

nasa/cFE#1978, Grammatical cleanup of requirements

nasa/cFE#1983, Build errors when using extended headers

Co-authored-by: Jacob Hageman   <[email protected]>
@jphickey jphickey deleted the fix-1982-exthdr-definition branch January 18, 2022 19:50
@skliper skliper added this to the Draco milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build errors when using extended headers
3 participants