-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1691, Add External Time Source Functional Tests #1783
Fix #1691, Add External Time Source Functional Tests #1783
Conversation
facea22
to
667d510
Compare
667d510
to
ddba337
Compare
|
||
UtAssert_INT32_EQ(CFE_TIME_RegisterSynchCallback(&TestCallbackFunction), CFE_SUCCESS); | ||
UtAssert_INT32_EQ(CFE_TIME_RegisterSynchCallback(&TestCallbackFunction2), CFE_TIME_TOO_MANY_SYNCH_CALLBACKS); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a 2 sec delay and check the CallbackFunction is called at least once? Could use the FT count global... Not a big deal but would be an easy functional check.
#endif | ||
|
||
UtPrintf("Testing: CFE_TIME_ExternalTone, CFE_TIME_ExternalMET, CFE_TIME_ExternalGPS, CFE_TIME_ExternalTime"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth a UtPrintf or comment here that the following time calls could impact the system timekeeping. Likely impact is incorrect time for one update cycle, a rejected external time update, multiple tone's or external updates detected, or similar. The call here confirms the implementation is properly included, more extensive timekeeping verification is a project/system responsibility.
CCB:2021-08-11 Needs more work |
Now it is ready |
2fb070a
to
7c0d1b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embedded...
7c0d1b7
to
2c07618
Compare
Fix #1691, Add External Time Source Functional Tests
**Combines** nasa/cFE#1808, v6.8.0-rc1+dev873 **Includes** - nasa/cFE#1790, Port "CFE_UtAssert_SuccessCheck" and related macros from coverage test to functional test #1784, add CFE assert macros to functional test - nasa/cFE#1779, Adds invalid id syslog to for CFE_ES_DeleteApp and CFE_ES_ReloadApp and verifies required reporting - nasa/cFE#1785, Stop memory leak & add cds size test. - nasa/cFE#1765, Mark read only inputs as const - nasa/cFE#1804, Check resource ID idx is less than max - nasa/cFE#1778, Add ES Application Behavior Functional Tests - nasa/cFE#1801, Update CFE_ES_RunLoop documentation - nasa/cFE#1745, Add Message Api Functional Test - nasa/cFE#1798, update in/out status and nonnull/nonzero tags - nasa/cFE#1783, Add External Time Source Functional Tests - nasa/cFE#1800, Add Perf API functional tests Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Paul <[email protected]>
**Combines** nasa/cFE#1808, v6.8.0-rc1+dev873 **Includes** - nasa/cFE#1790, Port "CFE_UtAssert_SuccessCheck" and related macros from coverage test to functional test #1784, add CFE assert macros to functional test - nasa/cFE#1779, Adds invalid id syslog to for CFE_ES_DeleteApp and CFE_ES_ReloadApp and verifies required reporting - nasa/cFE#1785, Stop memory leak & add cds size test. - nasa/cFE#1765, Mark read only inputs as const - nasa/cFE#1804, Check resource ID idx is less than max - nasa/cFE#1778, Add ES Application Behavior Functional Tests - nasa/cFE#1801, Update CFE_ES_RunLoop documentation - nasa/cFE#1745, Add Message Api Functional Test - nasa/cFE#1798, update in/out status and nonnull/nonzero tags - nasa/cFE#1783, Add External Time Source Functional Tests - nasa/cFE#1800, Add Perf API functional tests Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Paul <[email protected]>
Describe the contribution
Fixes #1691
Add External Time Source Functional Tests
Testing performed
Build and run unit test
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC