Fix #1655, Size unit test table load buffer based on config #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
jphickey
approved these changes
Jul 7, 2021
astrogeco
added
CCB:Approved
|
CCB:2021-07-07 APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 12, 2021
nasa/osal#1089, timer reconfig tests nasa/cFE#1656, Size unit test table load buffer based on config nasa/cFE#1657, Add SB Pipe Management Functional Tests
This was referenced Jul 12, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 13, 2021
**Combines:** nasa/cFE#1661, v6.8.0-rc1+dev746 nasa/osal#1100, v5.1.0-rc1+dev569 *Includes:* nasa/osal#1089, timer reconfig tests nasa/cFE#1656, Size unit test table load buffer based on config nasa/cFE#1657, Add SB Pipe Management Functional Tests
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 13, 2021
**Combines:** nasa/cFE#1661, v6.8.0-rc1+dev746 nasa/osal#1100, v5.1.0-rc1+dev569 *Includes:* nasa/osal#1089, timer reconfig tests nasa/cFE#1656, Size unit test table load buffer based on config nasa/cFE#1657, Add SB Pipe Management Functional Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1655 - Supports larger table configurations (in passing unit tests) by sizing the unit test buffer used for table loads based on the configuration values.
Testing performed
Increased CFE_PLATFORM_TBL_MAX_SNGL_TABLE_SIZE to where when multiplied by CFE_PLATFORM_TBL_MAX_SIMULTANEOUS_LOADS it would break the 128 * 1024 limit hard coded in ut_support.c. Built and ran unit tests, confirmed they now pass.
Expected behavior changes
Unit tests will pass for a configuration supporting larger tables
System(s) tested on
Additional context
Still not unlimited since table register uses the default buffer size, but an improvement.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC