cFE Integration candidate: 2021-06-22 #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test CFE_ES_ReloadApp bad AppID, core app, file doesn't exist Test CFE_ES_GetAppID: NULL AppID pointer Test CFE_ES_GetAppIDByName: NULL AppID pointer Test CFE_ES_GetAppIDByName: NULL name pointer Test CFE_ES_DeleteChildTask: Task inactive/invalid case Test CFE_ES_RegisterCDS: NULL handle and NULL name
Rename CFE coverage test assert macros in ut_support.h to have consistent name prefix. Adds implementation functions for completely generic signed/unsigned comparison asserts, and wrapper macros to invoke those functions. These functions return the pass/fail status of the assert as a bool value, so the test case can act on the result. Also adds a "VOIDCALL" and "RESOURCEID_EQ" macro for logging void functions and ID checks, respectively.
Fix #1626, rename/clean CFE coverage assert macros
Update ES coverage test to use preferred macros. Adds dedicated assert macros for checking fixed-length string buffers, and for checking memory offsets. Also adds an improved implemention of the syslog/printf check which filters out newlines (keeps log more parseable).
Update EVS coverage test to use preferred macros
Update SB coverage test to use preferred macros. Adds a dedicated assert macro for checking SB MsgId values.
Update MSG coverage test to use preferred macros
Update SBR coverage test to use preferred macros
Update TBL coverage test to use preferred macros
Update TIME coverage test to use preferred macros
Update FS coverage test to use preferred macros.
Clean up the assert functions and macros which are no longer used after updating all coverage tests to use preferred macros.
Add cfe_assert capability to "tee" all test log output to a file in addition to the regular output (console/event). This aids in scripting and automation, by creating a file containing only test results, not intermixed with other info, and not subject to the length limitations of events.
Add required coverage test cases to achieve 100% line coverage in FS
Fix #465, Added UT tests for cFE ES Api
…test Fix #1478, Expand CDS Functional Tests.
Fix #1625, add test log file
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 24, 2021
*Combines* - nasa/cFE#1632, v6.8.0-rc1+dev726 - nasa/osal#1079, v5.1.0-rc1+dev548 - nasa/ci_lab#88, v2.4.0-rc1+dev42 - nasa/sch_lab#83, v2.4.0-rc1+dev40 - nasa/sample_app#150, v1.2.0-rc1+dev66 - nasa/sample_lib#64, v1.2.0-rc1+dev38 - nasa/to_lab#100, v2.4.0-rc1+dev49 - nasa/elf2cfetbl#81, v3.2.0-rc1+dev30 - nasa/tblCRCTool#52, v1.2.0-rc1+dev33 - nasa/cFS-GroundSystem#183, v2.2.0-rc1+dev52 *Includes* - nasa/cFE#1630, correct path to users guide warning log - nasa/cFE#1621, add additional test cases for Child Tasks - nasa/cFE#1608, Add cfe functional tests to CI - nasa/cFE#1627, rename/clean CFE coverage assert macros - nasa/cFE#1623, Added UT tests for cFE ES Api - nasa/cFE#1634, Expand CDS Functional Tests. - nasa/cFE#1633, add test log file - nasa/cFE#1594, Event ID updates - nasa/cFE#1624, scrub all UT_Report calls - nasa/osal#1066, implement missing parameter/retcode test permutations - nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil - nasa/tblCRCTool#51, add printf conversion casts ** Implement Coding Standard in CodeQL ** - nasa/cFS-GroundSystem#180 - nasa/elf2cfetbl#80 - nasa/tblCRCTool#49 - nasa/ci_lab#87 - nasa/sch_lab#79 - nasa/sample_app#149 - nasa/sample_lib#63 - nasa/to_lab#99 Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of nasa/cFS#270
Testing
cFE Checks https://github.com/nasa/cFE/pull/1632/checks
Bundle Checks https://github.com/nasa/cfs/pull/270/checks
Authors
@skliper
@zanzaben
@jphickey
@pepepr08
Description
PR #1627
Fix #1626, rename/clean CFE coverage assert macros
PR #1630
Fix #1629, correct path to users guide warning log
PR #1621
Fix #1477, add additional test cases for Child Tasks
PR #1608
Fix #1367, Add cfe functional tests to CI
PR #1623
Fix #465, Added UT tests for cFE ES Api
PR #1634
Fix #1478, Expand CDS Functional Tests.
PR #1594
Fix #1320 #1583 #508, Event ID updates
PR #1633
Fix #1625, add test log file
PR #1624
Fix #596, scrub all UT_Report calls