Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1522, add printf format casts #1524

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Use (int) with %d conversions for portability

Fixes #1522

Testing performed
Build and run unit tests on RTEMS

Expected behavior changes
Build now succeeds

System(s) tested on
RTEMS 4.11.3

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Copy link
Contributor Author

Another issue crept into the latest main merge:

/home/joe/code/cfecfs/github/cfe/modules/cfe_testcase/src/time_current_test.c:89:5: error: format '%d' expects argument of type 'int', but argument 5 has type 'uint32' [-Werror=format=]
     UtPrintf("The current time is (%d) %s", Time.Seconds, timeBuf1);
     ^

Use (int) with %d conversions for portability
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 19, 2021
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label May 19, 2021
@astrogeco
Copy link
Contributor

CCB:2021-05-19 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate May 24, 2021 17:24
@astrogeco astrogeco merged commit a93304e into nasa:integration-candidate May 24, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Approved Indicates code review and approval by community CCB CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 24, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request May 24, 2021
Combines:

- nasa/cFE#1568
- nasa/osal#1050

Includes:

- nasa/cFE#1524, add printf format casts
- nasa/cFE#1520, accept "NULL" as entry point
- nasa/cfe #1549, add capability to generate multiple tables

- nasa/osal#1026, Add count sem timeout test
astrogeco added a commit to nasa/cFS that referenced this pull request May 26, 2021
Combines:

- cfe v6.8.0-rc1+dev593 (nasa/cFE#1568)
- osal v5.1.0-rc1+dev458 (nasa/osal#1050)

Includes:

- nasa/cFE#1524, add printf format casts
- nasa/cFE#1520, accept "NULL" as entry point
- nasa/cfe #1549, add capability to generate multiple tables
- nasa/cFE#1551, fixes discrepancies (return type, parameter names, etc) between function protoypes and implementation. Updates stubs accordingly

- nasa/osal#1026, Add count sem timeout test
- nasa/osal#1026, defer cancellation when BSP locked
@jphickey jphickey deleted the fix-1522-rtems-format branch June 8, 2021 18:21
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

printf format issue on RTEMS
3 participants