Fix #1049, replace OS_fsBlocksFree #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use OS_FileSysStatVolume() instead. This also enables the check to be more appropriate as this call reports the number of total blocks, not just the free blocks, so no workaround for desktop machines is needed.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jan 4, 2021
|
Depends on nasa/osal#717 |
astrogeco
added
CCB-20210106
dependency
and removed
CCB:Ready
|
CCB 2021-01-06 APPROVED depends on nasa/osal#717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Use
OS_FileSysStatVolume()instead ofOS_fsBlocksFree()which will be deprecated in the future.This also enables the check to be more appropriate as this call reports the number of total blocks, not just the free blocks, so no workaround for desktop machines is needed.
Fixes #1049
Testing performed
Build and run all unit tests
Sanity check CFE
Expected behavior changes
No impact to behavior.
System(s) tested on
Ubuntu 20.04
RTEMS 4.11
Additional context
No longer needs a workaround for running on desktop system, since the new API also returns the total blocks, not just free blocks.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.