You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Hk and Tbl RegPacket are initialized in both CFE_TBL_EarlyInit and CFE_TBL_InitData (called from CFE_TBL_TaskInit). The notify message packet is only initialized in CFE_TBL_SendNotificationMsg, and gets initialized every call.
The CFE_TBL_SendNotificationMsg could just be initialized once, then SetMsgId and SetFcnCode each time.
Describe the solution you'd like
These packets only need to be initialized once.
Describe alternatives you've considered
None.
Additional context
Observed when working on #777
Additional observation - the notification command gets timestamped, which fails for implementations where there is no time stamp in commands.
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Hk and Tbl RegPacket are initialized in both CFE_TBL_EarlyInit and CFE_TBL_InitData (called from CFE_TBL_TaskInit). The notify message packet is only initialized in CFE_TBL_SendNotificationMsg, and gets initialized every call.
cFE/fsw/cfe-core/src/tbl/cfe_tbl_internal.c
Lines 142 to 154 in e0d1ce8
cFE/fsw/cfe-core/src/tbl/cfe_tbl_internal.c
Lines 1511 to 1519 in e0d1ce8
cFE/fsw/cfe-core/src/tbl/cfe_tbl_task.c
Lines 247 to 256 in e0d1ce8
The CFE_TBL_SendNotificationMsg could just be initialized once, then SetMsgId and SetFcnCode each time.
Describe the solution you'd like
These packets only need to be initialized once.
Describe alternatives you've considered
None.
Additional context
Observed when working on #777
Additional observation - the notification command gets timestamped, which fails for implementations where there is no time stamp in commands.
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: