Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move entry point address info from app table to task table #978

Closed
jphickey opened this issue Oct 28, 2020 · 1 comment · Fixed by #1151 or #1171
Closed

Move entry point address info from app table to task table #978

jphickey opened this issue Oct 28, 2020 · 1 comment · Fixed by #1151 or #1171
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The ES global currently tracks task entry point in the app table, not task table. As a result only the "main" task entry point of an app is tracked in this regard. As child tasks are created, these all have different entry points, but they aren't stored, and therefore cannot be reported in the telemetry as reported via e.g. QUERY_ALL_TASKS.

Describe the solution you'd like
Hold the actual runtime entry point address in the Task table rather than the App table.

Additional context
This would simplify the current task entry logic as it would only need to look at the task entry, not the app+task entry combination.
Still would need to hang onto the configured (string version) of entry point for when an app is reloaded/restarted.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 28, 2020
@jphickey
Copy link
Contributor Author

Ping @acudmore for awareness -- this is what I had referred to in #960 (comment)

Separated out to a separate ticket so we can decide whether this is worth doing. I think it would be fairly easy and make it more logical, and make the task startup logic a little simpler too.

@jphickey jphickey mentioned this issue Oct 28, 2020
Closed
@skliper skliper added this to the 7.0.0 milestone Jan 22, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Feb 3, 2021
@jphickey
Fix nasa#978, store task parameters in task record
c8508d2 
Implement a "CFE_ES_TaskStartParams_t" to complement the
existing "CFE_ES_AppStartParams_t" and store this in the
task record.

This permits some nice cleanup:

- All tasks can now use the same basic start function CFE_ES_StartAppTask()
- No special/different logic is needed for main tasks/child tasks
- Simplified APIs as parameters can be encapsulated in a single struct.
- Fixes a race condition where child tasks may not be fully instantiated
  at the time the task function is invoked.
jphickey added a commit to jphickey/cFE that referenced this issue Feb 3, 2021
@jphickey
Fix nasa#978, store task parameters in task record
a0cda23 
Implement a "CFE_ES_TaskStartParams_t" to complement the
existing "CFE_ES_AppStartParams_t" and store this in the
task record.

This permits some nice cleanup:

- All tasks can now use the same basic start function CFE_ES_StartAppTask()
- No special/different logic is needed for main tasks/child tasks
- Simplified APIs as parameters can be encapsulated in a single struct.
- Fixes a race condition where child tasks may not be fully instantiated
  at the time the task function is invoked.
@jphickey jphickey mentioned this issue Feb 3, 2021
Merged
jphickey added a commit to jphickey/cFE that referenced this issue Feb 16, 2021
@jphickey
Fix nasa#978, store task parameters in task record
58abd38 
Implement a "CFE_ES_TaskStartParams_t" to complement the
existing "CFE_ES_AppStartParams_t" and store this in the
task record.

This permits some nice cleanup:

- All tasks can now use the same basic start function CFE_ES_StartAppTask()
- No special/different logic is needed for main tasks/child tasks
- Simplified APIs as parameters can be encapsulated in a single struct.
- Fixes a race condition where child tasks may not be fully instantiated
  at the time the task function is invoked.
@astrogeco astrogeco added the ES label Feb 17, 2021
astrogeco added a commit that referenced this issue Feb 24, 2021
@astrogeco
Merge pull request #1151 from jphickey/fix-978-entrypt
414036e 
Fix #978, put task parameters into task record
@astrogeco astrogeco mentioned this issue Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
3 participants
@jphickey @skliper @astrogeco