Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system-specific module and library suffixes to configdata struct #940

Closed
jphickey opened this issue Oct 7, 2020 · 0 comments · Fixed by #941 or #944
Closed

Add system-specific module and library suffixes to configdata struct #940

jphickey opened this issue Oct 7, 2020 · 0 comments · Fixed by #941 or #944
Assignees
@jphickey
Labels
build-system enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Oct 7, 2020

Is your feature request related to a problem? Please describe.
There are a number of use cases where the FSW could be improved if it knows the proper system-specific extension to use for modules and executable files.

See existing issues #611 and nasa/PSP#111

Describe the solution you'd like
Should add this information to the GLOBAL_CONFIGDATA structure, to make it available for PSP/CFE purposes.

Describe alternatives you've considered
Could also be provided in the GLOBAL_PSP_CONFIGDATA structure that resides in the PSP library, but this would require explicitly setting in each PSP.

Because CMake already knows this information and its readily available in CMake variables, its simpler and probably more reliable to just put it in the top level config struct based on the CMake value.

Requester Info
Joseph Hickey, Vantage Systems, Inc., (based off previous requests in other tickets)
@jphickey jphickey self-assigned this Oct 7, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Oct 7, 2020
@jphickey
Fix nasa#940, Add module suffix and core name to configdata
043b608 
Add the system-specific module suffix (.o, .so, .obj, etc) and the
default CFE core executable name to the configdata structure.

This information has several useful purposes.
@jphickey jphickey mentioned this issue Oct 7, 2020
Merged
jphickey added a commit to jphickey/cFE that referenced this issue Oct 8, 2020
@jphickey
Update nasa#940, add ifndef values for new fields
655a66c 
Adds an #ifndef empty string for the two new fields, which
at the very least prevents IDEs (e.g. Eclipse) from redlining
the value as an undefined symbol.

(It is always passed in on command line when building via CMake)
@astrogeco astrogeco added this to the 7.0.0 milestone Oct 13, 2020
astrogeco added a commit that referenced this issue Oct 13, 2020
@astrogeco
Merge pull request #941 from jphickey/fix-940-filename-configdata
b5ada30 
Fix #940, Add module suffix and core name to configdata
@astrogeco astrogeco mentioned this issue Oct 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
build-system enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @astrogeco