Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace calls OS_open and OS_create with OS_OpenCreate #893

Closed
jphickey opened this issue Sep 21, 2020 · 0 comments · Fixed by #895 or #912
Closed

Replace calls OS_open and OS_create with OS_OpenCreate #893

jphickey opened this issue Sep 21, 2020 · 0 comments · Fixed by #895 or #912
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For nasa/osal#556 the OS_open() and OS_create() API calls will be deprecated, because they don't follow the correct pattern of returning an OSAL ID via an output variable, instead returning the ID via the int32 return code.

Describe the solution you'd like
Use the newly exposed OSAL API OS_OpenCreate() which can replace both OS_open and OS_creat via different flags, and outputs the ID as all other OSAL functions do.

Additional context
Prerequisite to being able to deprecate these APIs that don't follow the OSAL pattern.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@skliper skliper added this to the 7.0.0 milestone Sep 21, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Sep 22, 2020
Use OS_OpenCreate instead, which has an API consistent with the
rest of OSAL.  OS_open and OS_create will be deprecated.
yammajamma added a commit that referenced this issue Sep 24, 2020
Fix #893, replace calls to OS_open and OS_creat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants